Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/build: doesn't set alltags for os for files with name name_os_arch.go #52053

Closed
matloob opened this issue Mar 30, 2022 · 1 comment
Closed

go/build: doesn't set alltags for os for files with name name_os_arch.go #52053

matloob opened this issue Mar 30, 2022 · 1 comment
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.19

Comments

@matloob
Copy link
Contributor

matloob commented Mar 30, 2022

I'm not sure if this is intended behavior, but figured i'd file this in case:

If you try to import golang.org/x/sys, alltags will not contain "netbsd" because the short-circuit evaluation of

		return matchTag(ctxt, l[n-1], allTags) && matchTag(ctxt, l[n-2], allTags)

in goodOSArchFile will not call matchtag with netbsd.
@gopherbot
Copy link

Change https://go.dev/cl/396918 mentions this issue: go/build: set allTags even when short-circuiting x_GOOS_GOARCH.go

@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 31, 2022
@bcmills bcmills added this to the Go1.19 milestone Mar 31, 2022
@golang golang locked and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Go1.19
Development

No branches or pull requests
3 participants
@bcmills @gopherbot @matloob