Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/types: documentation on instance de-duplication is unclear about guarantees [1.18 backport] #52028

Closed
gopherbot opened this issue Mar 30, 2022 · 2 comments
Closed

go/types: documentation on instance de-duplication is unclear about guarantees [1.18 backport] #52028

gopherbot opened this issue Mar 30, 2022 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases Documentation FrozenDueToAge
Milestone
Go1.18.2

Comments

@gopherbot
Copy link

@findleyr requested issue #51680 to be considered for backport to the next 1.18 minor release.

@gopherbot please backport to 1.18, this is important to clarify in our documentation.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 30, 2022
@gopherbot gopherbot mentioned this issue Mar 30, 2022
Closed
@gopherbot gopherbot added this to the Go1.18.1 milestone Mar 30, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/397674 mentions this issue: [release-branch.go1.18] go/types: clarify that contexts do not guarantee deduplication

@dmitshur dmitshur modified the milestones: Go1.18.1, Go1.18.2 Apr 12, 2022
@heschi heschi added the CherryPickApproved Used during the release process for point releases label Apr 20, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Apr 20, 2022
@gopherbot
Copy link
Author

Closed by merging 6fabc53 to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue May 9, 2022
@findleyr @heschi
[release-branch.go1.18] go/types: clarify that contexts do not guaran…
6fabc53 
…tee deduplication

Documentation around the use of types.Context is unclear about whether
contexts guarantee deduplication of identical instances. Add explicit
disclaimers that this is not the case.

Fixes #52028

Change-Id: I6651587315d3cbf9e8d70a69d3e2ec5cedd00da5
Reviewed-on: https://go-review.googlesource.com/c/go/+/396536
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
(cherry picked from commit 83327b4)
Reviewed-on: https://go-review.googlesource.com/c/go/+/397674
Reviewed-by: Russ Cox <rsc@golang.org>
@golang golang locked and limited conversation to collaborators May 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases Documentation FrozenDueToAge
Projects
None yet
Milestone
Go1.18.2
Development

No branches or pull requests
3 participants
@dmitshur @gopherbot @heschi