Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: semantic tokens for channel arrows are missing #52024

Closed
hyangah opened this issue Mar 30, 2022 · 2 comments
Closed

x/tools/gopls: semantic tokens for channel arrows are missing #52024

hyangah opened this issue Mar 30, 2022 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.8.4

Comments

@hyangah
Copy link
Contributor

hyangah commented Mar 30, 2022

Spin off from golang/vscode-go#2146 (comment)

Screen Shot 2022-03-29 at 10 02 38 AM

Arrows (<-) don't get semantic token info, so only textmate scopes are applied. (see the screenshot - I enabled the semantic token feature).

Screen Shot 2022-03-29 at 10 04 38 AM

gopls version v0.8.1
go version go1.18

cc @pjweinb
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Mar 30, 2022
@gopherbot gopherbot added this to the Unreleased milestone Mar 30, 2022
@li1234yun
Copy link

Related VSCode Issue

@pjweinb pjweinb self-assigned this Apr 1, 2022
@hyangah hyangah modified the milestones: Unreleased, gopls/v0.8.3 Apr 1, 2022
@findleyr findleyr modified the milestones: gopls/v0.8.3, gopls/v0.8.4 Apr 5, 2022
@pjweinb
Copy link

pjweinb commented Apr 24, 2022

397479 fixed this

@findleyr findleyr closed this as completed May 9, 2022
@rsc rsc unassigned pjweinb Jun 22, 2022
@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.8.4
Development

No branches or pull requests
5 participants
@hyangah @pjweinb @gopherbot @li1234yun @findleyr