Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: support patchset syntax for CL redirects #52023

Closed
rolandshoemaker opened this issue Mar 29, 2022 · 1 comment
Closed

x/website: support patchset syntax for CL redirects #52023

rolandshoemaker opened this issue Mar 29, 2022 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@rolandshoemaker
Copy link
Member

Currently the go.dev/cl/... redirect doesn't support patchset syntax, i.e. go.dev/cl/c/1234/5. This breaks some tooling, like Linkable, which generate shortened URLs using the typical Gerrit syntax (the assumption being that go.dev/cl/c/1234/5 will redirect to go-review.googlesource.com/c/1234/5) if you are trying to link to a specific patchset.

Dmitri suggested in http://go.dev/cl/396494 that we support linking to patchsets, but without the extra /c/ prefix that Gerrit uses (i.e. we'd redirect from go.dev/cl/1234/5 to go-review.googlesource.com/c/1234/5) which seems reasonable. This would require fixing how tooling like Linkable generate their shortened links, but that seems fine.

cc @dmitshur

@rolandshoemaker rolandshoemaker added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Mar 29, 2022
@gopherbot gopherbot added this to the Unreleased milestone Mar 29, 2022
@gopherbot
Copy link

Change https://go.dev/cl/396494 mentions this issue: internal/redirect: support cl patchset redirects

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Apr 11, 2022
@golang golang locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

3 participants