You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the go.dev/cl/... redirect doesn't support patchset syntax, i.e. go.dev/cl/c/1234/5. This breaks some tooling, like Linkable, which generate shortened URLs using the typical Gerrit syntax (the assumption being that go.dev/cl/c/1234/5 will redirect to go-review.googlesource.com/c/1234/5) if you are trying to link to a specific patchset.
Dmitri suggested in http://go.dev/cl/396494 that we support linking to patchsets, but without the extra /c/ prefix that Gerrit uses (i.e. we'd redirect from go.dev/cl/1234/5 to go-review.googlesource.com/c/1234/5) which seems reasonable. This would require fixing how tooling like Linkable generate their shortened links, but that seems fine.
Change https://go.dev/cl/396494 mentions this issue: internal/redirect: support cl patchset redirects
dmitshur
added
NeedsFix
The path to resolution is known, but the work has not been done.
and removed
NeedsDecision
Feedback is required from experts, contributors, and/or the community before a change can be made.
labels
Apr 11, 2022
Currently the
go.dev/cl/...
redirect doesn't support patchset syntax, i.e.go.dev/cl/c/1234/5
. This breaks some tooling, like Linkable, which generate shortened URLs using the typical Gerrit syntax (the assumption being thatgo.dev/cl/c/1234/5
will redirect togo-review.googlesource.com/c/1234/5
) if you are trying to link to a specific patchset.Dmitri suggested in http://go.dev/cl/396494 that we support linking to patchsets, but without the extra
/c/
prefix that Gerrit uses (i.e. we'd redirect fromgo.dev/cl/1234/5
togo-review.googlesource.com/c/1234/5
) which seems reasonable. This would require fixing how tooling like Linkable generate their shortened links, but that seems fine.cc @dmitshur
The text was updated successfully, but these errors were encountered: