Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sys/unix: TestPidfd fails on GOARCH mips builders #52014

Closed
mdlayher opened this issue Mar 29, 2022 · 8 comments
Closed

x/sys/unix: TestPidfd fails on GOARCH mips builders #52014

mdlayher opened this issue Mar 29, 2022 · 8 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@mdlayher
Copy link
Member

I implemented unix.Waitid in https://go-review.googlesource.com/c/sys/+/395936/, and @tklauser commented:

This CL seems to break the mips64-rtk, mips64le-rtk and mipsle-rtk builders:

 --- FAIL: TestPidfd (0.00s)
    syscall_linux_test.go:243: failed to check for child exit: invalid argument
FAIL
FAIL	[golang.org/x/sys/unix](http://golang.org/x/sys/unix)	0.684s

https://build.golang.org/log/405cfcebea4c1b0f00de4d988c2b1baf527b8008
https://build.golang.org/log/c2446e254921d971f655b00c86d5cb3aa2957e1a
https://build.golang.org/log/650f8e0343be7531952a38c71957f33ee6272e66

Maybe kernel version is too old on these builders?

For now, I will add a skip on EINVAL in this test.

/cc @tklauser @ianlancetaylor
@gopherbot gopherbot added this to the Unreleased milestone Mar 29, 2022
@gopherbot
Copy link

Change https://go.dev/cl/396154 mentions this issue: unix: skip Linux TestPidfd if Waitid returns EINVAL

@mdlayher
Copy link
Member Author

Ping @bogojevic @milanknezevic and @mengzhuo as the owners of these builders.

gopherbot pushed a commit to golang/sys that referenced this issue Mar 29, 2022
@mdlayher
unix: skip Linux TestPidfd if Waitid returns EINVAL
43be30e 
The updated test in CL 395936 appears to break GOARCH mips* builders.

Updates golang/go#52014

Change-Id: I42bb71d6afda2112a524257fd1b42306dd22689c
Reviewed-on: https://go-review.googlesource.com/c/sys/+/396154
Trust: Matt Layher <mdlayher@gmail.com>
Run-TryBot: Matt Layher <mdlayher@gmail.com>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@mengzhuo
Copy link
Contributor

linux-mipsle-mengzhuo runs on 5.4.110 is it affected?

@draganmladjenovic
Copy link

@mdlayher It looks like pidfd_open is introduced during 5.3 and waitid with P_PIDFD is introduced in 5.4. These machines are at 5.3.3*.

@mdlayher
Copy link
Member Author

Any chance these builders could be bumped to 5.10.x LTS? I believe that'd solve the immediate problem.

I don't have any context on mips or the builders, I'm just reporting what Tobias told me above. See logs.

@draganmladjenovic
Copy link

Not in the meantime. Not sure if there is another pidfd* syscall that can be easily used to construct the test instead of waitid.

@mdlayher
Copy link
Member Author

The test can stay skipped for now, no problem. Thanks.

@ianlancetaylor
Copy link
Contributor

The tests should pass on older (but still supported) kernel versions, and it sounds like that is what is happening now. So there is nothing to do. Closing. Thanks all.

@golang golang locked and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@mengzhuo @mdlayher @ianlancetaylor @gopherbot @draganmladjenovic