Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/fix: buildtag fix only kicks in with go.mod containing "go 1.18" or later #52011

Closed
gopherbot opened this issue Mar 29, 2022 · 1 comment
Closed

cmd/fix: buildtag fix only kicks in with go.mod containing "go 1.18" or later #52011

gopherbot opened this issue Mar 29, 2022 · 1 comment
Labels
FrozenDueToAge

Comments

@gopherbot
Copy link

@mvdan requested issue #51873 to be considered for backport to the next 1.18 minor release.

Going ahead with marking this for 1.18.1 for visibility. Happy for the backport issue to be removed if my conclusions are wrong.

@gopherbot, please backport to Go 1.18. This seems like a go fix bug which contradicts the release notes.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 29, 2022
@gopherbot gopherbot mentioned this issue Mar 29, 2022
Closed
@gopherbot gopherbot added this to the Go1.18.1 milestone Mar 29, 2022
@mvdan
Copy link
Member

mvdan commented Mar 30, 2022

Closing per #51873 (comment).

@mvdan mvdan closed this as completed Mar 30, 2022
@mvdan mvdan removed the CherryPickCandidate Used during the release process for point releases label Mar 30, 2022
@mvdan mvdan removed this from the Go1.18.1 milestone Mar 30, 2022
@mvdan mvdan changed the title cmd/fix: buildtag fix only kicks in with go.mod containing "go 1.18" or later [1.18 backport] cmd/fix: buildtag fix only kicks in with go.mod containing "go 1.18" or later Mar 30, 2022
@golang golang locked and limited conversation to collaborators Mar 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mvdan @gopherbot