Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/types, types2: scope is unset on receivers of instantiated methods [1.18 backport] #52007

Closed
gopherbot opened this issue Mar 29, 2022 · 3 comments
Closed

go/types, types2: scope is unset on receivers of instantiated methods [1.18 backport] #52007

gopherbot opened this issue Mar 29, 2022 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.18.1

Comments

@gopherbot
Copy link

@findleyr requested issue #51920 to be considered for backport to the next 1.18 minor release.

@gopherbot please consider this for backport to 1.18, it is an oversight.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 29, 2022
@gopherbot gopherbot mentioned this issue Mar 29, 2022
Closed
@gopherbot gopherbot added this to the Go1.18.1 milestone Mar 29, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/395680 mentions this issue: go/types, types2: preserve parent scope when substituting receivers

@heschi heschi added the CherryPickApproved Used during the release process for point releases label Mar 30, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Mar 30, 2022
@heschi
Copy link
Contributor

heschi commented Mar 30, 2022

Presumably will cause gopls some trouble, approved.

@gopherbot
Copy link
Author

Closed by merging 6412231 to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue Apr 4, 2022
@findleyr @cherrymui
[release-branch.go1.18] go/types, types2: preserve parent scope when …
6412231 
…substituting receivers

For #51920
Fixes #52007

Change-Id: I29e44a52dabee5c09e1761f9ec8fb2e8795f8901
Reviewed-on: https://go-review.googlesource.com/c/go/+/395538
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Robert Griesemer <gri@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 9b90838)
Reviewed-on: https://go-review.googlesource.com/c/go/+/395680
@golang golang locked and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.18.1
Development

No branches or pull requests
2 participants
@gopherbot @heschi