Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: go vet: Printf incorrect type check in generic method #51968

Closed
ogau opened this issue Mar 26, 2022 · 1 comment
Closed

x/tools/gopls: go vet: Printf incorrect type check in generic method #51968

ogau opened this issue Mar 26, 2022 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@ogau
Copy link

ogau commented Mar 26, 2022

Type in printf function for floating-point verb is specified correctly, but go vet shows this as an error

gopls version

gopls v0.8.1

Editor and settings

vscode 1.65.2

"gopls": {
       "ui.diagnostic.staticcheck": true,
       "ui.completion.usePlaceholders": true,
       "ui.diagnostic.analyses": {
           // "fieldalignment": true,
           "nilness": true,
           "shadow": true,
           "unusedparams": true,
           "unusedwrite": true
       },
       "ui.diagnostic.annotations": {
           "bounds": true,
           "escape": true,
           "inline": true,
           "nil": true
       },
   },

What did you see?

image
image
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Mar 26, 2022
@gopherbot gopherbot added this to the Unreleased milestone Mar 26, 2022
@fzipp
Copy link
Contributor

fzipp commented Mar 26, 2022

Your float64 is not what you think it is: https://go.dev/doc/faq#types_in_method_declaration

@golang golang locked and limited conversation to collaborators Mar 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@fzipp @gopherbot @seankhliao @ogau