cmd/compile: slow with many methods on parameterized type #51957
Comments
|
Can you build and run the test separately? Build with |
|
Sure: # edited comparable_test.go and added `// hi` at the top, then saved, then:
$> time go test -c
go test -c 59.77s user 4.67s system 247% cpu 26.078 totalIt is the build of the test binary. Execution is slow compared to Go 1.17 but not as much as the build: $> time go test -timeout 10s ./... -count 1 -run "TestComparableStream_.*"
ok github.com/seborama/fuego/v11 0.344s
? github.com/seborama/fuego/v11/generate [no test files]
go test -timeout 10s ./... -count 1 -run "TestComparableStream_.*" 2.43s user 0.74s system 134% cpu 2.352 total |
seankhliao
changed the title
seankhliao
added
the
NeedsInvestigation
|
For comparison, I've created a new branch time go test -c
go test -c 0.92s user 0.56s system 222% cpu 0.665 totaltime go test -timeout 10s ./... -count 1 -run "TestComparableStream_.*"
ok github.com/seborama/fuego/v11 0.138s
? github.com/seborama/fuego/v11/generate [no test files]
go test -timeout 10s ./... -count 1 -run "TestComparableStream_.*" 0.77s user 0.61s system 188% cpu 0.732 total |
|
There appears to be just a lot of code generated by this package. Like, 74302 functions. For instance, there are 24299 functions that all came from I'm not entirely sure that all of these instantiations are necessary, but at first look there's nothing obviously duplicated. |
* v11: transition to go 1.18 type parameters (WIP) * add interface implementation checks * Checkpoint * Initial ground zero * Some updates to README (WIP) * Makefile * added common type aliases and improved tests * more tests, tweaks * re-org'ed files * FlatMap also fix go.mod versioning * add Predicate * added: predicate, stream.Filter * added TestStream_ForEach * doc updates * added Stream.MapTo* generated code * added: LeftReduce, Reduce and BiFunctions: Max, Min, Sum * README, renamed a param * Licence file * README * refined generated code (adding FlatMapTo* as well) * added tests * add ComparableStream with Max and Min * add ComparableStream.Sum * test branch for Issue 51957 See golang/go#51957 * Attempt to move forward with Go 1.18 * Add Average, replace Addable with Mathable Small corrections * added Stream.GroupBy * added collectors * added missing test * README updates * add optional + more collectors, etc
|
I'd argue that my attempt to use methods with a generic receiver (and then back-fill with functions) is probably inadequate in my use-case. This article refers: |
gopherbot
added
the
compiler/runtime
What version of Go are you using (
go version)?Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (
go env)?go envOutputWhat did you do?
git clone git@github.com:seborama/fuego.git -b v11_type_parameters && cd fuegoEdit file
comparable_test.goand add a comment anywhere in the file then save. This step is to ensure the build is executed without caching.go test -timeout 10s -v ./... -count 1 -run TestComparableStream_MaxThe execution of the test takes over 1 minute on my computer, rather than < 3s normally.
This problem may have started after I added
mapto.go(generated viamake generate).The reason for generating so many parameterised methods comes from issue 49085.
What did you expect to see?
A fast test execution, at most 3 seconds, likely under 1s.
What did you see instead?
The outcome is correct, but the test build takes a drastically long time.
Right now, I only have one computer on which to test this issue.
This may conceivably be related to an unknown particular of my environment set-up, although I cannot think of any.
The text was updated successfully, but these errors were encountered: