Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: either stop trimming the AST or don't print the confusing errors that result #51948

Closed
pjweinb opened this issue Mar 25, 2022 · 1 comment
Closed

x/tools/gopls: either stop trimming the AST or don't print the confusing errors that result #51948

pjweinb opened this issue Mar 25, 2022 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@pjweinb
Copy link

pjweinb commented Mar 25, 2022

In the latest version of gopls i get errors like
17:19:07 falling back to safe trimming due to type errors: [/usr/local/google/home/pjw/go/pkg/mod/github.com/google/go-cmp@v0.5.7/cmp/options.go:469:24: invalid operation: signed shift count iota (untyped int constant 0) requires go1.13 or later
that result from trimming the AST.

I am running go 1.18.

These are confusing, so either they or their cause should be suppressed. Was AST trimming put in for some sort of performance improvement?
@findleyr findleyr changed the title gopls: either stop trimming the AST or don't print the confusing errors that result x/tools/gopls: either stop trimming the AST or don't print the confusing errors that result Mar 25, 2022
@findleyr findleyr transferred this issue from golang/vscode-go Mar 25, 2022
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Mar 25, 2022
@gopherbot gopherbot added this to the Unreleased milestone Mar 25, 2022
@pjweinb
Copy link
Author

pjweinb commented Mar 25, 2022

this is a duplicate. closed

@pjweinb pjweinb closed this as completed Mar 25, 2022
@golang golang locked and limited conversation to collaborators Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@pjweinb @gopherbot