Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http/httptest: race in Close [1.18 backport] #51897

Closed
gopherbot opened this issue Mar 23, 2022 · 2 comments
Closed

net/http/httptest: race in Close [1.18 backport] #51897

gopherbot opened this issue Mar 23, 2022 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.18.2

Comments

@gopherbot
Copy link

@rsc requested issue #51799 to be considered for backport to the next 1.18 minor release.

@gopherbot please open backports for Go 1.18
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 23, 2022
@gopherbot gopherbot mentioned this issue Mar 23, 2022
Closed
@gopherbot gopherbot added this to the Go1.18.1 milestone Mar 23, 2022
@dmitshur dmitshur modified the milestones: Go1.18.1, Go1.18.2 Apr 12, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/401317 mentions this issue: [release-branch.go1.18] net/http/httptest: fix race in Server.Close

@neild neild mentioned this issue Apr 20, 2022
Closed
@dr2chase dr2chase added the CherryPickApproved Used during the release process for point releases label May 4, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label May 4, 2022
@gopherbot
Copy link
Author

Closed by merging 4556843 to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue May 9, 2022
@maisem @heschi
[release-branch.go1.18] net/http/httptest: fix race in Server.Close
4556843 
When run with race detector the test fails without the fix.

For #51799
Fixes #51897

Change-Id: I273adb6d3a2b1e0d606b9c27ab4c6a9aa4aa8064
GitHub-Last-Rev: a5ddd14
GitHub-Pull-Request: #51805
Reviewed-on: https://go-review.googlesource.com/c/go/+/393974
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Trust: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
(cherry picked from commit 1d19cea)
Reviewed-on: https://go-review.googlesource.com/c/go/+/401317
Reviewed-by: David Chase <drchase@google.com>
@golang golang locked and limited conversation to collaborators May 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.18.2
Development

No branches or pull requests
3 participants
@dmitshur @dr2chase @gopherbot