Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/pointer: example breaks with generics in sync/atomic #51889

Closed
rsc opened this issue Mar 23, 2022 · 2 comments
Closed

x/tools/go/pointer: example breaks with generics in sync/atomic #51889

rsc opened this issue Mar 23, 2022 · 2 comments
Labels
Analysis Issues related to static analysis (vet, x/tools/go/analysis) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Go1.19

Comments

@rsc
Copy link
Contributor

rsc commented Mar 23, 2022

https://go.dev/cl/381317 is failing on x/tools/go/pointer
because that package is trying to do something with all
the dependencies of fmt, and sync/atomic is adding a use
of generics—Pointer[T]—in its API.

I believe that @timothy-king's work on go/ssa may fix this,
but it hasn't landed yet and he is on vacation.
So for now I am filing this bug and will disable
x/tools/go/pointer/example_test.go.
@rsc rsc added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 23, 2022
@rsc rsc added this to the Go1.19 milestone Mar 23, 2022
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Mar 23, 2022
@gopherbot
Copy link

Change https://go.dev/cl/394974 mentions this issue: go/pointer: disable tests that break with generics in std

@zpavlinovic zpavlinovic added the Analysis Issues related to static analysis (vet, x/tools/go/analysis) label Mar 25, 2022
@timothy-king timothy-king self-assigned this Mar 28, 2022
@timothy-king
Copy link
Contributor

I expect this to be working after https://go-review.googlesource.com/c/tools/+/397854. I cherry picked https://go.dev/cl/394974 into gotip and ran:

% gotip test -timeout 30s -run ^Example$ golang.org/x/tools/go/pointer
ok      golang.org/x/tools/go/pointer   0.733s

Closing for now. Please re-open if this is not working for you.

@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Analysis Issues related to static analysis (vet, x/tools/go/analysis) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Go1.19
Development

No branches or pull requests
4 participants
@rsc @timothy-king @zpavlinovic @gopherbot