-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposal: strconv: export unquote and appendQuotedWith #51887
Comments
So what's the proposal? |
Make |
CC @dsnet |
the |
We had this discussion on #45033 and decided not to export unquote. I don't see any new evidence here. |
"You don't always want to parse it, but you always need to identify a boundary." Really? For whatever reason, various data mining setups still rely very strongly on CSV style files. Huge CSV style files, where there are many strings, escapes abundant and fields are separated by a single ascii codepoint. By providing a crippled API in the runtime, you're basically saying: don't use it, just go for third-party/self implemented solution. Yep, that's what we do all the time. But then, why pollute the runtime with useless things? |
Based on the discussion above, this proposal seems like a likely decline. |
No change in consensus, so declined. |
Follow up to #45033
There's a perfectly good function in the
strconv
package calledunquote
.unquote
does things most text parsing applications need. Instead of making it public, per the original proposal, we've got the totally superfluousQuotedPrefix
, which requires us to parse the source string twice.Moreover,
appendQuotedWith
is a really useful companion function and should be made public as well.The text was updated successfully, but these errors were encountered: