Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/types, types2: consolidate error messages for composite literals #51879

Closed
griesemer opened this issue Mar 23, 2022 · 1 comment
Closed

go/types, types2: consolidate error messages for composite literals #51879

griesemer opened this issue Mar 23, 2022 · 1 comment
Assignees
@griesemer
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.20

Comments

@griesemer
Copy link
Contributor

The error messages for composite literals sometimes report a type, sometimes they don't. The phrasing is not consistent.
Should clean up and ensure that the same amount of information (or better) is reported as with the 1.17 compiler.

Follow-up on #51877.
@griesemer griesemer added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 23, 2022
@griesemer griesemer added this to the Go1.19 milestone Mar 23, 2022
@griesemer griesemer self-assigned this Mar 23, 2022
@griesemer griesemer modified the milestones: Go1.19, Go1.20 Jun 23, 2022
@gopherbot
Copy link

Change https://go.dev/cl/438855 mentions this issue: go/types, types2: use consistent error messages for invalid struct literals

@golang golang locked and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@griesemer griesemer

Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Release Status & Release Blockers
Status: Done
Milestone
Go1.20
Development

No branches or pull requests
2 participants
@griesemer @gopherbot