-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: a 2022 pass to delete unused commands and packages #51867
Comments
Change https://go.dev/cl/394515 mentions this issue: |
Change https://go.dev/cl/394514 mentions this issue: |
Change https://go.dev/cl/394518 mentions this issue: |
Change https://go.dev/cl/394516 mentions this issue: |
Change https://go.dev/cl/394517 mentions this issue: |
Change https://go.dev/cl/394519 mentions this issue: |
Change https://go.dev/cl/394520 mentions this issue: |
See CLs gopherbot mentioned above. The current stack ends with https://go.dev/cl/394520. |
Help users avoid incorrect expectations of stability, and help us avoid incurring needless maintenance overhead. For golang/go#51867. Fixes golang/go#36505. Change-Id: I78377711ff2d5441bcdc4186dc8708167cf1a952 Reviewed-on: https://go-review.googlesource.com/c/build/+/394514 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Carlos Amedee <carlos@golang.org> Trust: Dmitri Shuralyov <dmitshur@golang.org>
Change https://go.dev/cl/396477 mentions this issue: |
The version package and inner commands are long since deprecated, having been replaced by the equivalent golang.org/dl/... packages. Go 1.10 and 1.9 are not supported according to release policy, so no one should be depending these by now. Delete them. For golang/go#51867. Change-Id: If4e89673b600e1fd0cfd50a117c95232d1d6a663 Reviewed-on: https://go-review.googlesource.com/c/build/+/394515 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Carlos Amedee <carlos@golang.org> Trust: Dmitri Shuralyov <dmitshur@golang.org>
The CRFS project has long since moved, and no one is looking for it in x/build by now. Remove its directory. For golang/go#51867. Change-Id: I91a6b6614d284fbf731d71641870ae2dcb55c67c Reviewed-on: https://go-review.googlesource.com/c/build/+/394516 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Carlos Amedee <carlos@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Than McIntosh <thanm@google.com>
This command exists for debugging only, and has probably outlived its usefulness by now. For golang/go#51867. Change-Id: Ibe87108b9b6e66092ffe7e997be084c9fd1150c3 Reviewed-on: https://go-review.googlesource.com/c/build/+/394519 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Carlos Amedee <carlos@golang.org> Reviewed-by: Than McIntosh <thanm@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
We haven't used this code in many years. Remove it as unused. If a specific need comes up, we can get it back from history. Doing that isn't much harder compared to figuring out how to use it after all those years. For golang/go#51867. Fixes golang/go#34259. Fixes golang/go#27632. Change-Id: Icda2c077fd10c48812e2e59b8d19386abd7f9357 Reviewed-on: https://go-review.googlesource.com/c/build/+/394517 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Carlos Amedee <carlos@golang.org> Reviewed-by: Than McIntosh <thanm@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
Change https://go.dev/cl/405547 mentions this issue: |
From information available to me, this command isn't actively used now. It was created in 2015 to help find CLs that need attention, but by now there are newer processes (e.g., gopherbot assigning reviewers, the go.dev/s/needs-review link, the dev.golang.org/reviews page) that contribute to it being obsolete. Its last meaningful change was in 2016 just to keep it working with Go 1.8. Having this checked in in x/build implies that it's supported, but that doesn't appear to be the case. If we did want to keep it supported and invest more effort into it, it would be better to share more code with an equivalent web view at https://dev.golang.org/reviews rather than have two very similar implementations with subtly different logic. Its code remains available in history if it becomes needed again, but it's not meeting the bar to stay checked in to x/build. For golang/go#51867. Change-Id: I6241bd38d8e828d28a2c31a26bf2d4794c87cf51 Reviewed-on: https://go-review.googlesource.com/c/build/+/394518 Reviewed-by: Carlos Amedee <carlos@golang.org> Reviewed-by: Than McIntosh <thanm@google.com> Reviewed-by: Benny Siegert <bsiegert@gmail.com>
This function was actively used a few years ago, but by now it's not serving any purpose. If it (or a modified version thereof) becomes needed again, it's easy to re-add. In the meantime, delete its code to reduce x/build maintenance costs slightly. For golang/go#51867. Change-Id: I4962cc5a6384541ca4f38003565b2cdc218c0c51 Reviewed-on: https://go-review.googlesource.com/c/build/+/396477 Reviewed-by: Heschi Kreinick <heschi@google.com> Reviewed-by: Carlos Amedee <carlos@golang.org>
x/build has accumulated some code that in 2022 is no longer relevant and not used for Go's build system or development of the Go programming language in any way. Since x/build is for internal needs (see #36505), we don't need to keep it just because of backwards compatibility—we can delete it from the main branch.
That way it's not tested in TryBots needlessly, doesn't distract us when working in x/build, and in general makes it so x/build on tip holds only what is current. This is to help reduce maintenance costs and make the volume of code that needs to be maintained by the @golang/release team to keep the current system going closer to the realistic minimum.
I've gone over everything in x/build, and there's surprisingly not as many things as I thought that can be outright pruned. I'll send out a CL stack for review and discussion.
The text was updated successfully, but these errors were encountered: