-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile: crash on pointer conversion in call to mapaccess2 [1.18 backport] #51849
Comments
On #51840, it's reported that 115c3bf happened to fix this issue. I think that CL will backport cleanly to 1.18, but I think it will break -G=0 mode. If we want to fix for 1.18, I can prepare a backport fix that doesn't break -G=0. It would be just keeping the old logic for -G=0, and the new logic for -G=3 and unified IR. |
Change https://go.dev/cl/405436 mentions this issue: |
Crash on valid code. Approved. |
Closed by merging e1b14f5 to release-branch.go1.18. |
This CL is a manual backport of CLs 403837 and 404914 to Go 1.18. CL 403837 was intended just as a simplification CL, but evidently it also fixed #51840. However, for backporting to Go 1.18, the existing logic needs to be preserved to support -G=0 mode (which still relies on Ntype). Fixes #51849. Change-Id: Ib060b0bc67ecf26de8a65d5b4d2f8a65cd547517 Reviewed-on: https://go-review.googlesource.com/c/go/+/405436 Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: Keith Randall <khr@google.com>
@ianlancetaylor requested issue #51840 to be considered for backport to the next 1.18 minor release.
The text was updated successfully, but these errors were encountered: