Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: internal compiler error: walkExpr: switch 1 unknown op RECOVER [1.18 backport] #51846

Closed
gopherbot opened this issue Mar 21, 2022 · 3 comments
Closed

cmd/compile: internal compiler error: walkExpr: switch 1 unknown op RECOVER [1.18 backport] #51846

gopherbot opened this issue Mar 21, 2022 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.18.1

Comments

@gopherbot
Copy link

@ianlancetaylor requested issue #51839 to be considered for backport to the next 1.18 minor release.

@gopherbot Please open backport to 1.18

This is an internal compiler error on valid code.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 21, 2022
@gopherbot gopherbot mentioned this issue Mar 21, 2022
Closed
@gopherbot gopherbot added this to the Go1.18.1 milestone Mar 21, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/394080 mentions this issue: [release-branch.go1.18] cmd/compile: fix panic with nested dead hidden closures

@toothrot toothrot added the CherryPickApproved Used during the release process for point releases label Mar 23, 2022
@toothrot
Copy link
Contributor

Approved. This is a serious issue with no workaround.

@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Mar 23, 2022
@gopherbot
Copy link
Author

Closed by merging c258e9d to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue Apr 4, 2022
@cuonglm @cherrymui
[release-branch.go1.18] cmd/compile: fix panic with nested dead hidde…
c258e9d 
…n closures

CL 342350 fixed deadcode panic with dead hidden closures. However, a
closure may contains nested dead hidden closures, so we need to mark
them dead as well.

Fixes #51846

Change-Id: Ib54581adfc1bdea60e74d733cd30fd8e783da983
Reviewed-on: https://go-review.googlesource.com/c/go/+/394079
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/394080
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
@golang golang locked and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.18.1
Development

No branches or pull requests
2 participants
@toothrot @gopherbot