Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: '' is rendered as smart doublequotes in <pre> block #51807

Closed
kortschak opened this issue Mar 19, 2022 · 6 comments
Closed

x/pkgsite: '' is rendered as smart doublequotes in <pre> block #51807

kortschak opened this issue Mar 19, 2022 · 6 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Milestone
pkgsite/unplanned

Comments

@kortschak
Copy link
Contributor

kortschak commented Mar 19, 2022 •
edited

What is the URL of the page with the issue?

https://pkg.go.dev/github.com/google/cel-go@v0.10.1/ext#hdr-Join

What is your user agent?

Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:98.0) Gecko/20100101 Firefox/98.0

Screenshot

Screenshot from 2022-03-19 20-09-39

What did you do?

What did you expect to see?

No smart quotes in <pre> blocks.

What did you see instead?

Smart quotes in <pre> blocks.
@gopherbot gopherbot added this to the pkgsite/unplanned milestone Mar 19, 2022
@kortschak kortschak changed the title x/pkgsite: x/pkgsite: '' is rendered at smart doublequotes in <pre> block Mar 19, 2022
@kortschak kortschak changed the title x/pkgsite: '' is rendered at smart doublequotes in <pre> block x/pkgsite: '' is rendered as smart doublequotes in <pre> block Mar 19, 2022
@gopherbot
Copy link

Change https://go.dev/cl/394034 mentions this issue: internal/godoc/dochtml/internal/render: don't smart quote in <pre> blocks

@kortschak
Copy link
Contributor Author

On further thought, given that authors can already encode “ and ” through unicode in the source if they really want it, and the quote conversion makes it impossible to express things like empty strings from some other languages (and empty raw strings in Go) and quoted single quotes in SQL, I think it would be better to just remove this feature.

@mvdan
Copy link
Member

mvdan commented Mar 20, 2022

I would also remove "quote conversion" entirely, not just in <pre> blocks, but perhaps I'm missing what was the point of adding that in the first place.

@seebs
Copy link
Contributor

seebs commented Mar 20, 2022

"Smart" quote conversion isn't.

@jamalc jamalc added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Apr 1, 2022
@jamalc
Copy link

jamalc commented Apr 7, 2022

Let's limit this issue to removing the conversion in <pre> blocks to fix the bug.

@kortschak
Copy link
Contributor Author

@jamalc I will send another PR completely removing this for discussion. Given the changes that @rsc has made in the content in https://go.dev/cl/384262 changing '' to “ and ” it would make sense not to double process, particularly given the issues I raise above.

@kortschak kortschak mentioned this issue Jul 16, 2022
Closed
@golang golang locked and limited conversation to collaborators Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Projects
None yet
Milestone
pkgsite/unplanned
Development

No branches or pull requests
5 participants
@seebs @kortschak @mvdan @gopherbot @jamalc