Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: Dead links for sub-repositories #51785

Closed
sakjur opened this issue Mar 18, 2022 · 1 comment
Closed

x/website: Dead links for sub-repositories #51785

sakjur opened this issue Mar 18, 2022 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@sakjur
Copy link

sakjur commented Mar 18, 2022

What did you do?

Got 404 when following links from go1compat to golang.org/x/sys.

What did you expect to see?

End result: if I click on the link in a browser, I'd expected to be redirected to https://pkg.go.dev/golang.org/x/net

Presumably, this would be either by means of the URL being an absolute https://golang.org/x/net as it was before or go.dev resolving https://go.dev/x/net the same as golang.org.

What did you see instead?

golang/website@ab4f479 changed all links to go.dev or golang.org to relative links, including links to sub-repositories under golang.org/x, so that they now link to https://go.dev/x/net (not found) instead of https://golang.org/x/net (redirecting to the docs of the package).

The problem seems to be present in the following places:

./_content/doc/go1.4.html:130:using the supporting packages in the <a href="/x/mobile">mobile</a> subrepository.
./_content/doc/go1.4.html:615:A new subrepository, <a href="/x/sys">golang.org/x/sys</a>,
./_content/doc/go1.7.html:40:<a href="/x/net/context">x/net subrepository</a>
./_content/doc/go1compat.html:167:<a href="/x/net">golang.org/x/net</a>,
./_content/doc/go1compat.html:184:<a href="/x/sys">go.sys</a> subrepository.
./_content/doc/go1.6.html:281:<a href="/x/net/http2"><code>golang.org/x/net/http2</code></a>,

I know this could've been a very small CL submission instead, however, I think I'd have to ask my employer to sign the CLA for me to do so, and that seems like a chore I'd rather do without this time. 🙈

@gopherbot gopherbot added this to the Unreleased milestone Mar 18, 2022
@sakjur sakjur changed the title x/website: x/website: Dead links for sub-repositories Mar 18, 2022
@seankhliao seankhliao added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 18, 2022
@gopherbot
Copy link

Change https://go.dev/cl/394815 mentions this issue: _content: fix links to x repos

passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
Fixes golang/go#51785

Change-Id: Ic5efc91122f83b92ce37de1cd402f3bba3b84cf1
Reviewed-on: https://go-review.googlesource.com/c/website/+/394815
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Trust: Dmitri Shuralyov <dmitshur@google.com>
@golang golang locked and limited conversation to collaborators Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

3 participants