Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/websocket: allow for reading and sending cookies, other HTTP headers #5178

Closed
slimsag opened this issue Apr 1, 2013 · 4 comments
Closed

x/net/websocket: allow for reading and sending cookies, other HTTP headers #5178

slimsag opened this issue Apr 1, 2013 · 4 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@slimsag
Copy link

slimsag commented Apr 1, 2013 

What steps will reproduce the problem?
    Currently go.net/websocket provides no way to send cookies back over the initial WebSocket HTTP "Upgrade" request (the first request made).

    In my current application, because of this we must send another single useless HTTP request in order to get cookies back from the Go server.

    There was an discussion about this exact issue on the ML back in 2011 (see https://groups.google.com/forum/?fromgroups=#!topic/golang-nuts/5dxVevxkMa0)

What is the expected output?
go.net/websocket should provide an way to read and respond to cookies (and possibly
other headers?) in an close manner to the way net/http allows you to.
@ukai
Copy link
Contributor

ukai commented May 12, 2013

Comment 2:

This issue was closed by revision golang/net@0005f0a.

Status changed to Fixed.

@gopherbot
Copy link

Comment 3 by nyu@paperboardinc.com:

how do I read cookies from websocket.conn???? My wesocket.conn header is nil

@gopherbot
Copy link

Comment 4:

The link in comment #2 is broken (404).

@gopherbot
Copy link

Comment 5:

Reverse engineered this:
https://code.google.com/p/go/source/detail?r=1e65ca1b2499&repo=net

@mikioh mikioh added repo-net and removed repo-net labels Dec 23, 2014
@mikioh mikioh changed the title go.net/websocket: allow for reading and sending cookies, other HTTP headers websocket: allow for reading and sending cookies, other HTTP headers Jan 4, 2015
@mikioh mikioh changed the title websocket: allow for reading and sending cookies, other HTTP headers x/net/websocket: allow for reading and sending cookies, other HTTP headers Jul 30, 2015
@mikioh mikioh modified the milestone: Unreleased Jul 30, 2015
@golang golang locked and limited conversation to collaborators Aug 5, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@mikioh @ukai @slimsag @gopherbot