Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/regtest/watch: failures in TestDeleteFiles #51772

Closed
bcmills opened this issue Mar 17, 2022 · 4 comments
Closed

x/tools/gopls/internal/regtest/watch: failures in TestDeleteFiles #51772

bcmills opened this issue Mar 17, 2022 · 4 comments
Assignees
@findleyr
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.13.0

Comments

@bcmills
Copy link
Contributor

bcmills commented Mar 17, 2022 

--- FAIL: TestDeleteFiles (7.39s)
    --- FAIL: TestDeleteFiles/delete_then_close (2.00s)
        --- FAIL: TestDeleteFiles/delete_then_close/singleton (0.35s)
            watch_test.go:429: waiting on:
                	Unmeetable: once "completed work \"diagnosing opened files\" at least 2 time(s)" is met, must have "log message matching \"a_unneeded.go\" expected 1 times"
                
                err:condition has final verdict Unmeetable
                
                state:
                #### log messages (see RPC logs for full text):
                	Info: "2022/03/16 01:47:26 go env for /tmp/workdir/tmp/go...
                	Info: "2022/03/16 01:47:26 40.756228ms for GOROOT=/tmp/wo...
                	Info: "2022/03/16 01:47:26 87.117632ms for GOROOT=/tmp/wo...
                	Info: "2022/03/16 01:47:26 go/packages.Load\n\tsnapshot=0...
                	Info: "2022/03/16 01:47:26 go/packages.Load\n\tsnapshot=0...
                	Info: "2022/03/16 01:47:26 85.280814ms for GOROOT=/tmp/wo...
                
                #### diagnostics:
                
                #### outstanding work:
                #### completed work:
                	Load: 1
                	Setting up workspace: 1
                	diagnosing initial workspace load: 1
                	diagnosing opened files: 2
FAIL
FAIL	golang.org/x/tools/gopls/internal/regtest/watch	26.318s

greplogs --dashboard -md -l -e 'FAIL: TestDeleteFiles' --omit=openbsd-.\*-n2d\|dragonfly-amd64 --since=2022-01-01

2022-03-16T01:41:57-77aa08b-4aa1efe/freebsd-amd64-12_3
2022-01-18T18:56:51-f29bdf1-75bcdd5/windows-arm64-10
2022-01-12T19:47:40-d7a4bb4-f005df8/windows-arm64-10
2022-01-07T22:46:47-94bfe68-7f3eb61/netbsd-amd64-9_0-n1

(CC @findleyr)
@bcmills bcmills added gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Mar 17, 2022
@bcmills bcmills changed the title x/tools/gopls/internal/regtest/watch: failure in TestDeleteFiles x/tools/gopls/internal/regtest/watch: failures in TestDeleteFiles Mar 17, 2022
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Mar 17, 2022
@gopherbot gopherbot added this to the Unreleased milestone Mar 17, 2022
@suzmue suzmue modified the milestones: Unreleased, gopls/on-deck Mar 18, 2022
@findleyr findleyr added Testing An issue that has been verified to require only test changes, not just a test failure. and removed gopls/testing labels May 10, 2022
@bcmills
Copy link
Contributor Author

bcmills commented May 24, 2022 •
edited

greplogs --dashboard -md -l -e 'FAIL: TestDeleteFiles' --since=2022-03-17
2022-05-23T18:40:59-ccb1050-74f0ccb/netbsd-amd64-9_0
2022-04-04T10:59:27-153e30b-1af60b2/windows-amd64-race
2022-04-04T04:04:18-153e30b-884e75f/windows-amd64-longtest
2022-03-22T20:46:22-1428e83-817d6ea/netbsd-386-9_0

(Note that although windows/amd64 is a first-class port, the two windows/amd64 failures above were fallout from CL 367495, which was subsequently reverted.)

@bcmills
Copy link
Contributor Author

bcmills commented May 31, 2022

Recent unattributed failures seem to be mostly (or entirely?) on NetBSD. 🤔

(CC @golang/netbsd)

greplogs --dashboard -md -l -e 'FAIL: TestDeleteFiles' --since=2022-05-24
2022-05-27T15:13:07-0e859af-42f1b37/netbsd-amd64-9_0

@findleyr
Copy link
Contributor

Another failure that can plausibly be explained by my misunderstanding of log sequencing.

@gopherbot
Copy link

Change https://go.dev/cl/513097 mentions this issue: gopls: fix tests that depend on log sequencing

@findleyr findleyr modified the milestones: gopls/later, gopls/v0.13.0 Jul 26, 2023
@findleyr findleyr self-assigned this Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findleyr findleyr

Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.13.0
Development

No branches or pull requests
4 participants
@bcmills @suzmue @gopherbot @findleyr