Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/cgo: pointer to incomplete C type is mangled when passed through interface type and generic type assert [1.18 backport] #51741

Closed
gopherbot opened this issue Mar 17, 2022 · 3 comments
Closed

cmd/cgo: pointer to incomplete C type is mangled when passed through interface type and generic type assert [1.18 backport] #51741

gopherbot opened this issue Mar 17, 2022 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.18.1

Comments

@gopherbot
Copy link
Contributor

@ianlancetaylor requested issue #51733 to be considered for backport to the next 1.18 minor release.

@gopherbot Please open backport to 1.18

This appears to be invalid code generation, so we should backport a fix when we have one.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 17, 2022
@gopherbot gopherbot mentioned this issue Mar 17, 2022
Closed
@gopherbot gopherbot added this to the Go1.18.1 milestone Mar 17, 2022
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/393935 mentions this issue: [release-branch.go1.18] cmd/compile: pointers to notinheap types need their own shape

@toothrot toothrot added the CherryPickApproved Used during the release process for point releases label Mar 23, 2022
@toothrot
Copy link
Contributor

Approved. This is a serious issue with no workaround.

@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Mar 23, 2022
@gopherbot
Copy link
Contributor Author

Closed by merging f4d5566 to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue Apr 4, 2022
@randall77 @cherrymui
[release-branch.go1.18] cmd/compile: pointers to notinheap types need…
f4d5566 
… their own shape

They should not share a shape with regular pointers. We could coalesce
multiple pointer-to-not-in-heap types, but doesn't seem worth it - just
make them fully stenciled.

Fixes #51741

Change-Id: Ie8158177226fbc46a798e71c51897a82f15153df
Reviewed-on: https://go-review.googlesource.com/c/go/+/393895
Trust: Keith Randall <khr@golang.org>
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
(cherry picked from commit fcf6afb)
Reviewed-on: https://go-review.googlesource.com/c/go/+/393935
@golang golang locked and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.18.1
Development

No branches or pull requests
2 participants
@toothrot @gopherbot