Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin: tls handshake panic: unreachable method called. linker bug? [1.18 backport] #51737

Closed
gopherbot opened this issue Mar 17, 2022 · 3 comments
Closed

plugin: tls handshake panic: unreachable method called. linker bug? [1.18 backport] #51737

gopherbot opened this issue Mar 17, 2022 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.18.1

Comments

@gopherbot
Copy link

@zhouguangyuan0718 requested issue #51621 to be considered for backport to the next 1.18 minor release.

Well, it's ingenious. Maybe we need a backport to 1.17 and 1.18?
@gopherbot please open a backport issue.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 17, 2022
@gopherbot gopherbot mentioned this issue Mar 17, 2022
Closed
@gopherbot gopherbot added this to the Go1.18.1 milestone Mar 17, 2022
@toothrot toothrot added the CherryPickApproved Used during the release process for point releases label Mar 23, 2022
@toothrot
Copy link
Contributor

Approved. This fixes a valid-usecase of plugins with a trivial targeted fix.

@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Mar 23, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/397483 mentions this issue: [release-branch.go1.18] cmd/link: mark unexported methods for plugins

@gopherbot
Copy link
Author

Closed by merging 290883a to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue Apr 4, 2022
@cherrymui
[release-branch.go1.18] cmd/link: mark unexported methods for plugins
290883a 
When plugin is used, we already mark all exported methods
reachable. However, when the plugin and the host program share
a common package, an unexported method could also be reachable
from both the plugin and the host via interfaces. We need to mark
them as well.

Fixes #51737.
Updates #51621.

Change-Id: I1a70d3f96b66b803f2d0ab14d00ed0df276ea500
Reviewed-on: https://go-review.googlesource.com/c/go/+/393365
Trust: Cherry Mui <cherryyz@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
(cherry picked from commit 91631bc)
Reviewed-on: https://go-review.googlesource.com/c/go/+/397483
@golang golang locked and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.18.1
Development

No branches or pull requests
2 participants
@toothrot @gopherbot