Skip to content

x/vuln: vuln DB should report its last-modified time #51735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jba opened this issue Mar 16, 2022 · 1 comment
Closed

x/vuln: vuln DB should report its last-modified time #51735

jba opened this issue Mar 16, 2022 · 1 comment
Labels
FeatureRequest Issues asking for a new feature that does not need a proposal. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Milestone

Comments

@jba
Copy link
Contributor

jba commented Mar 16, 2022

The vuln DB client in x/vuln should have a method that reports the last-modified time of the DB (or DBs).

This will allow systems that periodically check for vulnerabilities to skip those checks if the DB hasn't changed since the last one.

@jba jba added the FeatureRequest Issues asking for a new feature that does not need a proposal. label Mar 16, 2022
@gopherbot gopherbot added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Mar 16, 2022
@gopherbot gopherbot added this to the Unreleased milestone Mar 16, 2022
@heschi heschi added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 17, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/394874 mentions this issue: client: add LastModifiedTime

@golang golang locked and limited conversation to collaborators Mar 23, 2023
softdev050 added a commit to softdev050/Golangvuln that referenced this issue Apr 5, 2023
Add a LastModifiedTime method to Client so that tools that poll the DB
can easily determine whether it has changed.

Fixes golang/go#51735

Change-Id: Idb07ed924ec256234f9eba7467429ab2fd1f2430
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/394874
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
sayjun0505 added a commit to sayjun0505/Golangvuln that referenced this issue Apr 8, 2023
Add a LastModifiedTime method to Client so that tools that poll the DB
can easily determine whether it has changed.

Fixes golang/go#51735

Change-Id: Idb07ed924ec256234f9eba7467429ab2fd1f2430
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/394874
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
stanislavkononiuk added a commit to stanislavkononiuk/Golangvuln that referenced this issue Jun 26, 2023
Add a LastModifiedTime method to Client so that tools that poll the DB
can easily determine whether it has changed.

Fixes golang/go#51735

Change-Id: Idb07ed924ec256234f9eba7467429ab2fd1f2430
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/394874
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FeatureRequest Issues asking for a new feature that does not need a proposal. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Projects
Status: No status
Development

No branches or pull requests

4 participants
@gopherbot @jba @heschi and others