Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gerritbot: broken by use of unauthenticated Git, no longer supported by GitHub #51722

Closed
heschi opened this issue Mar 16, 2022 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@heschi
Copy link
Contributor

heschi commented Mar 16, 2022

From the gerritbot logs:

2022-03-16 12:37:27.535 EDT2022/03/16 16:37:27 processPullRequest: importGerritChangeFromPR(golang/go#51612, [...]): running [git -C /root/.cache/gerritbot/tmp/worktree_golang_go_51612 fetch github pull/51612/head]: output: fatal: remote error:
Error
2022-03-16 12:37:27.535 EDT The unauthenticated git protocol on port 9418 is no longer supported.
Error
2022-03-16 12:37:27.535 EDTPlease see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.
@heschi heschi added the Soon This needs to be done soon. (regressions, serious bugs, outages) label Mar 16, 2022
@heschi heschi self-assigned this Mar 16, 2022
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Mar 16, 2022
@gopherbot gopherbot added this to the Unreleased milestone Mar 16, 2022
@gopherbot
Copy link

Change https://go.dev/cl/393375 mentions this issue: cmd/gerritbot: use https:// for cloning

@heschi
Copy link
Contributor Author

heschi commented Mar 16, 2022

I deployed the CL above early and it fixed the problem.

@heschi heschi removed the Soon This needs to be done soon. (regressions, serious bugs, outages) label Mar 16, 2022
@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 16, 2022
@dmitshur dmitshur added this to Done in Go Release Team Mar 17, 2022
@rsc rsc unassigned heschi Jun 22, 2022
@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Archived in project
Development

No branches or pull requests

3 participants