Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: mistaken run command on workspaces tutorial page #51693

Closed
ClaytonXia opened this issue Mar 16, 2022 · 3 comments
Closed

x/website: mistaken run command on workspaces tutorial page #51693

ClaytonXia opened this issue Mar 16, 2022 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@ClaytonXia
Copy link

What is the URL of the page with the issue?

https://go.dev/doc/tutorial/workspaces

What is your user agent?

Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.72 Safari/537.36

Screenshot

image

What did you do?

Run command: go run example/hello

What did you expect to see?

HELLO

What did you see instead?

package example/hello is not in GOROOT

Fix

I guess the command should be go run example.com/hello. Isn't it?
@gopherbot gopherbot added this to the Unreleased milestone Mar 16, 2022
@fzipp
Copy link
Contributor

fzipp commented Mar 16, 2022

Yes, it should be go run example.com/hello.

There's another bug in the tutorial:

  1. Add the new function.
    [...]
    Add a new folder to the workspace/example/stringutil directory containing the following contents:

This should be "Add a new file ..."

@dmitshur
Copy link
Contributor

Thanks for reporting.

CC @matloob.

@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 16, 2022
@dmitshur dmitshur changed the title x/website: Mistaken run command on tutorial page x/website: mistaken run command on workspaces tutorial page Mar 16, 2022
@hallazzang hallazzang mentioned this issue Mar 17, 2022
Closed
@seankhliao
Copy link
Member

Fixed in CL 393360

@golang golang locked and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@fzipp @dmitshur @gopherbot @seankhliao @ClaytonXia