Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: fails to deploy with Go 1.18 #51686

Closed
heschi opened this issue Mar 15, 2022 · 12 comments
Closed

x/website: fails to deploy with Go 1.18 #51686

heschi opened this issue Mar 15, 2022 · 12 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@heschi
Copy link
Contributor

heschi commented Mar 15, 2022

golang.org is failing to deploy due to failing tests:

Step #6: testdata/web.txt:272: code = "500", want "200"
Step #6: 
Step #6: ## GET https://go.dev/pkg/net/http/?m=old
Step #6: testdata/web.txt:277: GET https://go.dev/pkg/net/http/?m=old
Step #6: testdata/web.txt:278: body does not contain `title="Added in Go 1.11"` (but should)

https://tip.golang.org/pkg/net/http/?m=old shows:

to, err := human()
//go:build comment without // +build comment

For now we're going to keep the website on 1.17.

cc @rsc @golang/release
@heschi heschi added the Soon This needs to be done soon. (regressions, serious bugs, outages) label Mar 15, 2022
@heschi heschi added this to the Unreleased milestone Mar 15, 2022
@dmitshur
Copy link
Contributor

This is related to golang.org/x/website/cmd/golangorg being currently deployed to App Engine with go116 runtime:

https://github.com/golang/website/blob/18753261dd3ced20943afdc947097527359d3f63/cmd/golangorg/app.yaml#L5

I'll send a CL to x/website to add the latest spec documents as a temporary workaround while this issue is worked on.

@heschi heschi mentioned this issue Mar 15, 2022
Closed
@gopherbot
Copy link

Change https://go.dev/cl/393115 mentions this issue: _content/doc: temporarily add Go language specification documents

gopherbot pushed a commit to golang/website that referenced this issue Mar 15, 2022
@dmitshur
_content/doc: temporarily add Go language specification documents
2e3ad7d 
The canonical location for these documents is in the main Go repository
in the doc directory. Due to go.dev/issue/51686, the website is using
Go content from release-branch.go1.17 rather than release-branch.go1.18.

Temporarily add a copy of the spec docs to x/website so it's possible to
view them at go.dev (in addition to tip.golang.org) while that issue is
being resolved.

For golang/go#51686.

Change-Id: Ia6640d6c32af631f562db1294d191f461373b9ee
Reviewed-on: https://go-review.googlesource.com/c/website/+/393115
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Trust: Dmitri Shuralyov <dmitshur@google.com>
@rsc
Copy link
Contributor

rsc commented Mar 15, 2022

Well that's embarrassing. I will vendor in a copy of go/build I guess.

@rsc rsc self-assigned this Mar 15, 2022
@rsc
Copy link
Contributor

rsc commented Mar 15, 2022

So was tip just broken for a long time and we didn't notice?

@dmitshur
Copy link
Contributor

dmitshur commented Mar 15, 2022 •
edited

@rsc I expect so, at least since those old-style // +build comments were removed on tip, thought can't back that up without looking closer.

I'm not sure if there's more work involved in updating x/website's documentation rendering to handle generics. I left #48264 (comment) but that issue was about x/pkgsite.

@dmitshur
Copy link
Contributor

#44356 (comment) suggests the https://tip.golang.org/pkg/net/http/?m=old problem existed since Oct 28, 2021.

@rsc
Copy link
Contributor

rsc commented Mar 15, 2022

Oh, and the tip redirect meant that most people didn't notice.

@gopherbot
Copy link

Change https://go.dev/cl/393194 mentions this issue: all: handle Go 1.18 code on Go 1.16 AppEngine using new internal/backport/go/*

@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 15, 2022
gopherbot pushed a commit to golang/website that referenced this issue Mar 15, 2022
@rsc
all: handle Go 1.18 code on Go 1.16 AppEngine using new internal/back…
7a60f30 
…port/go/*

The immediate need was go/build, because the Go 1.16 go/build rejects
code that has //go:build without // +build, as Go 1.18 code now does.

But displaying code using generics would also have failed, for inability
to parse that code. Add the full go/ast, go/doc, go/format, go/parser,
go/printer, go/scanner, and go/token to fix those failures, which
would become more frequent as generics are used more inside the
standard library.

The code is all from the go1.18 tag of the Go repo, post-processed to
rewrite imports and apply gofmt -w -r 'any -> interface{}' to keep it
building with the other backports and with Go 1.16 syntax.

For golang/go#51686.

Change-Id: I1e14f4634d8bc09bdaa04c014eadb1be97ea5047
Reviewed-on: https://go-review.googlesource.com/c/website/+/393194
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
@Jacalz Jacalz mentioned this issue Mar 16, 2022
Closed
@dmitshur dmitshur mentioned this issue Mar 16, 2022
Closed
@rsc
Copy link
Contributor

rsc commented Mar 16, 2022

The web site is serving the Go 1.18 tree now. Leaving open because I think Dmitri wanted to roll back CL 393115.

@dmitshur
Copy link
Contributor

I'll do that, making sure the spec isn't changing as a result (it shouldn't). Removing Soon since this is mostly mitigated. Thank you Russ.

@dmitshur dmitshur removed the Soon This needs to be done soon. (regressions, serious bugs, outages) label Mar 16, 2022
@gopherbot
Copy link

Change https://go.dev/cl/393355 mentions this issue: _content/doc: revert "temporarily add Go language specification documents"

@cherrymui cherrymui mentioned this issue Jun 9, 2022
Closed
@rsc rsc removed their assignment Jun 22, 2022
@gopherbot
Copy link

Change https://go.dev/cl/414515 mentions this issue: api: correct debug/pe issue number for Go 1.19 changes

gopherbot pushed a commit that referenced this issue Jun 28, 2022
@rsc
api: correct debug/pe issue number for Go 1.19 changes
d3ffff2 
It was #51868 not #51686.

For #53310.

Change-Id: I2cf28ca4de65e7030fdbd05e7f32fe42c8f3ca0a
Reviewed-on: https://go-review.googlesource.com/c/go/+/414515
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
@dmitshur dmitshur mentioned this issue Aug 2, 2022
Closed
jproberts pushed a commit to jproberts/go that referenced this issue Aug 10, 2022
@rsc @jproberts
api: correct debug/pe issue number for Go 1.19 changes
beec7fa 
It was golang#51868 not golang#51686.

For golang#53310.

Change-Id: I2cf28ca4de65e7030fdbd05e7f32fe42c8f3ca0a
Reviewed-on: https://go-review.googlesource.com/c/go/+/414515
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
_content/doc: temporarily add Go language specification documents
f475db4 
The canonical location for these documents is in the main Go repository
in the doc directory. Due to go.dev/issue/51686, the website is using
Go content from release-branch.go1.17 rather than release-branch.go1.18.

Temporarily add a copy of the spec docs to x/website so it's possible to
view them at go.dev (in addition to tip.golang.org) while that issue is
being resolved.

For golang/go#51686.

Change-Id: Ia6640d6c32af631f562db1294d191f461373b9ee
Reviewed-on: https://go-review.googlesource.com/c/website/+/393115
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Trust: Dmitri Shuralyov <dmitshur@google.com>
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
all: handle Go 1.18 code on Go 1.16 AppEngine using new internal/back…
76a9fbf 
…port/go/*

The immediate need was go/build, because the Go 1.16 go/build rejects
code that has //go:build without // +build, as Go 1.18 code now does.

But displaying code using generics would also have failed, for inability
to parse that code. Add the full go/ast, go/doc, go/format, go/parser,
go/printer, go/scanner, and go/token to fix those failures, which
would become more frequent as generics are used more inside the
standard library.

The code is all from the go1.18 tag of the Go repo, post-processed to
rewrite imports and apply gofmt -w -r 'any -> interface{}' to keep it
building with the other backports and with Go 1.16 syntax.

For golang/go#51686.

Change-Id: I1e14f4634d8bc09bdaa04c014eadb1be97ea5047
Reviewed-on: https://go-review.googlesource.com/c/website/+/393194
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
_content/doc: revert "temporarily add Go language specification docum…
7dbec8f 
…ents"

Revert commit 2e3ad7d979299962a9e843e8eb77f28f337c37cb (CL 393115).
By now, the website is using Go content from release-branch.go1.18,
so this temporary mitigation is no longer needed.

Fixes golang/go#51686.

Change-Id: I47e3962cdffd88c708e1c150d9cf4bdcac217b24
Reviewed-on: https://go-review.googlesource.com/c/website/+/393355
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Trust: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
@golang golang locked and limited conversation to collaborators Jun 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@rsc @dmitshur @gopherbot @heschi