Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encoding/binary: add AppendUvarint and AppendVarint #51644

Closed
thatradius opened this issue Mar 13, 2022 · 6 comments
Closed

encoding/binary: add AppendUvarint and AppendVarint #51644

thatradius opened this issue Mar 13, 2022 · 6 comments
Labels
FrozenDueToAge Proposal Proposal-Accepted Proposal-FinalCommentPeriod
Projects
Proposals (old)
Milestone
Go1.19

Comments

@thatradius
Copy link

#50601 introduced AppendByteOrder, so it would be nice if we had

func AppendUvarint(buf []byte, x uint64) []byte
func AppendVarint(buf []byte, x int64) []byte
@gopherbot gopherbot added this to the Proposal milestone Mar 13, 2022
@ianlancetaylor
Copy link
Contributor

CC @dsnet

@ianlancetaylor ianlancetaylor added this to Incoming in Proposals (old) Mar 14, 2022
@rsc
Copy link
Contributor

rsc commented Mar 16, 2022

Seems OK and it would match not just binary.LittleEndian.AppendUint32 but also things like strconv.AppendQuote.

@rsc rsc moved this from Incoming to Active in Proposals (old) Mar 16, 2022
@rsc
Copy link
Contributor

rsc commented Mar 16, 2022

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

@rsc
Copy link
Contributor

rsc commented Mar 23, 2022

Based on the discussion above, this proposal seems like a likely accept.
— rsc for the proposal review group

@rsc rsc moved this from Active to Likely Accept in Proposals (old) Mar 23, 2022
@randall77 randall77 mentioned this issue Mar 23, 2022
Closed
@rsc rsc moved this from Likely Accept to Accepted in Proposals (old) Mar 30, 2022
@rsc
Copy link
Contributor

rsc commented Mar 30, 2022

No change in consensus, so accepted. 🎉
This issue now tracks the work of implementing the proposal.
— rsc for the proposal review group

@rsc rsc changed the title proposal: encoding/binary: add AppendUvarint and AppendVarint encoding/binary: add AppendUvarint and AppendVarint Mar 30, 2022
@rsc rsc modified the milestones: Proposal, Backlog Mar 30, 2022
@gopherbot
Copy link

Change https://go.dev/cl/400176 mentions this issue: encoding/binary: add AppendVarint AppendUvarint

@dmitshur dmitshur modified the milestones: Backlog, Go1.19 Apr 15, 2022
@cherrymui cherrymui mentioned this issue Jun 9, 2022
Closed
@dsnet dsnet mentioned this issue Jul 5, 2022
Closed
@golang golang locked and limited conversation to collaborators Apr 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Proposal Proposal-Accepted Proposal-FinalCommentPeriod
Projects
No open projects
Proposals (old)
Accepted
Milestone
Go1.19
Development

No branches or pull requests
5 participants
@rsc @dmitshur @ianlancetaylor @gopherbot @thatradius