Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/types: mismatching 'indirect' results from NewMethodSet and LookupFieldOrMethod for interface methods #51592

Open
findleyr opened this issue Mar 10, 2022 · 3 comments
Open

go/types: mismatching 'indirect' results from NewMethodSet and LookupFieldOrMethod for interface methods #51592

findleyr opened this issue Mar 10, 2022 · 3 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.23

Comments

@findleyr
Copy link
Contributor

For T below, we get different results for whether or not m is indirect when using the NewMethodSet vs LookupFieldOrMethod APIs:

type T interface{ m() }

https://go.dev/play/p/yvswbEovSem

Unless I'm misunderstanding, these APIs should agree.

CC @griesemer
@findleyr findleyr added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 10, 2022
@findleyr findleyr added this to the Go1.19 milestone Mar 10, 2022
@ianlancetaylor
Copy link
Contributor

@findleyr @griesemer What is the current status here? This issue is currently in the 1.19 milestone. Should it move to 1.20? To Backlog? Thanks.

@findleyr
Copy link
Contributor Author

This bug has existed for a long time. Let's try to fix for 1.20.

@findleyr findleyr modified the milestones: Go1.19, Go1.20 Jun 24, 2022
@findleyr findleyr modified the milestones: Go1.20, Go1.21 Nov 10, 2022
@findleyr
Copy link
Contributor Author

Unfortunately we don't have bandwidth for this fix, and it is a low priority. Moving to 1.21.

@gopherbot gopherbot modified the milestones: Go1.21, Go1.22 Aug 8, 2023
@findleyr findleyr mentioned this issue Oct 11, 2023
Open
@findleyr findleyr modified the milestones: Go1.22, Go1.23 Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Release Status & Release Blockers
Status: No status
Milestone
Go1.23
Development

No branches or pull requests
3 participants
@ianlancetaylor @gopherbot @findleyr