Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: playground's textbox has poor contrast #51584

Closed
dominikh opened this issue Mar 10, 2022 · 5 comments
Closed

x/website: playground's textbox has poor contrast #51584

dominikh opened this issue Mar 10, 2022 · 5 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. website
Milestone
Unreleased

Comments

@dominikh
Copy link
Member

The playground has rather poor contrast now:
image

Looking at the CSS, the text's color is var(--color-text-subtle). I think it goes without saying that the text shouldn't be subtle.
@gopherbot gopherbot added this to the Unreleased milestone Mar 10, 2022
@seebs
Copy link
Contributor

seebs commented Mar 10, 2022

it apparently does not in fact go without saying, but strongly agreed. it's good to have reasonably high contrast. too-high can be uncomfortable, but this is starting to be too faint to read easily.

@gopherbot
Copy link

Change https://go.dev/cl/391394 mentions this issue: _content: fix go.dev/play text color

@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 10, 2022
@Deleplace
Copy link
Contributor

I strongly agree that the input code and the output didn't have a strong enough contrast.

Thank you Egon.

Before CL 391394

image

After CL 391394

image

@gopherbot
Copy link

Change https://go.dev/cl/391535 mentions this issue: _content/css: improve contrast for playground and dark theme elements

@jamalc
Copy link

jamalc commented Mar 10, 2022

Thanks for reporting this, we fixed this in CL 391535 as part of a set of bug fixes for the dark theme.

@jamalc jamalc closed this as completed Mar 10, 2022
@jamalc jamalc reopened this Mar 10, 2022
@jamalc jamalc self-assigned this Mar 10, 2022
gopherbot pushed a commit to golang/website that referenced this issue Mar 10, 2022
@jamalc
_content/css: improve contrast for playground and dark theme elements
13c3316 
For golang/go#34601.
Fixes golang/go#51584.

Change-Id: I0a1715eacb5e3cef51aff7285dbdf9a0a5a6ea3c
Reviewed-on: https://go-review.googlesource.com/c/website/+/391535
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Trust: Jamal Carvalho <jamalcarvalho@google.com>
@rsc rsc unassigned jamalc Jun 22, 2022
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
_content: fix go.dev/play text color
41f3dba 
The text color in go.dev/play was accidentally set to color-text-subtle
in CL 384874 whereas the correct color is color-text.

Fixes golang/go#51584

Change-Id: I0a512d826bb88dc16db032334350935503724f09
Reviewed-on: https://go-review.googlesource.com/c/website/+/391394
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Valentin Deleplace <deleplace@google.com>
Reviewed-by: Russ Cox <rsc@golang.org>
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
_content/css: improve contrast for playground and dark theme elements
9563fef 
For golang/go#34601.
Fixes golang/go#51584.

Change-Id: I0a1715eacb5e3cef51aff7285dbdf9a0a5a6ea3c
Reviewed-on: https://go-review.googlesource.com/c/website/+/391535
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Trust: Jamal Carvalho <jamalcarvalho@google.com>
@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. website
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
6 participants
@dominikh @seebs @dmitshur @gopherbot @Deleplace @jamalc