Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/types, types2: revisit implementation LookupFieldOrMethod #51580

Closed
griesemer opened this issue Mar 10, 2022 · 1 comment
Closed

go/types, types2: revisit implementation LookupFieldOrMethod #51580

griesemer opened this issue Mar 10, 2022 · 1 comment
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.19

Comments

@griesemer
Copy link
Contributor

Reminder issue. We currently have a TODO in lookup.go:

// TODO(gri) The named type consolidation and seen maps below must be
//           indexed by unique keys for a given type. Verify that named
//           types always have only one representation (even when imported
//           indirectly via different packages.)

Instantiated types may not be represented by unique keys which may lead to incorrect behavior.

cc: @findleyr
@griesemer griesemer added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 10, 2022
@griesemer griesemer added this to the Go1.19 milestone Mar 10, 2022
@griesemer griesemer self-assigned this Mar 10, 2022
@findleyr findleyr mentioned this issue May 5, 2022
Closed
@gopherbot
Copy link

Change https://go.dev/cl/404099 mentions this issue: go/types, types2: use a type lookup by identity in method lookup

@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Go1.19
Development

No branches or pull requests
2 participants
@griesemer @gopherbot