Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime/pprof: TestCPUProfileRecursion failures due to CL 384239 #51567

Closed
prattmic opened this issue Mar 9, 2022 · 1 comment
Closed

runtime/pprof: TestCPUProfileRecursion failures due to CL 384239 #51567

prattmic opened this issue Mar 9, 2022 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.19

Comments

@prattmic
Copy link
Member

prattmic commented Mar 9, 2022 

--- FAIL: TestCPUProfileRecursion (0.21s)
    pprof_test.go:524: total 4 CPU profile samples collected:
        1: 0x100143130 (runtime/pprof.inlinedCallee:304 runtime/pprof.recursionCallee:355) 0x100143167 (runtime/pprof.recursionCallee:356) 0x1001430b3 (runtime/pprof.recursionCaller:347) 0x1001415ff (runtime/pprof.cpuHogger:41) 0x100142dbf (runtime/pprof.TestCPUProfileRecursion.func1:329) 0x10014354f (runtime/pprof.testCPUProfile:451) 0x100142e7f (runtime/pprof.TestCPUProfileRecursion:328) 0x1000d3b17 (testing.tRunner:1439) labels: map[]
        
        1: 0x100143150 (runtime/pprof.cpuHog0:64 runtime/pprof.inlinedCallee:304 runtime/pprof.recursionCallee:355 runtime/pprof.recursionCallee:355) 0x100143167 (runtime/pprof.recursionCallee:356) 0x100143167 (runtime/pprof.recursionCallee:356) 0x1001430b3 (runtime/pprof.recursionCaller:347) 0x1001415ff (runtime/pprof.cpuHogger:41) 0x100142dbf (runtime/pprof.TestCPUProfileRecursion.func1:329) 0x10014354f (runtime/pprof.testCPUProfile:451) 0x100142e7f (runtime/pprof.TestCPUProfileRecursion:328) 0x1000d3b17 (testing.tRunner:1439) labels: map[]
        
        1: 0x100143140 (runtime/pprof.cpuHog0:61 runtime/pprof.inlinedCallee:304 runtime/pprof.recursionCallee:355 runtime/pprof.recursionCallee:355) 0x100143167 (runtime/pprof.recursionCallee:356) 0x1001430b3 (runtime/pprof.recursionCaller:347) 0x1001415ff (runtime/pprof.cpuHogger:41) 0x100142dbf (runtime/pprof.TestCPUProfileRecursion.func1:329) 0x10014354f (runtime/pprof.testCPUProfile:451) 0x100142e7f (runtime/pprof.TestCPUProfileRecursion:328) 0x1000d3b17 (testing.tRunner:1439) labels: map[]
        
        1: 0x100143150 (runtime/pprof.cpuHog0:64 runtime/pprof.inlinedCallee:304 runtime/pprof.recursionCallee:355 runtime/pprof.recursionCallee:355) 0x100143167 (runtime/pprof.recursionCallee:356) 0x1001430b3 (runtime/pprof.recursionCaller:347) 0x1001415ff (runtime/pprof.cpuHogger:41) 0x100142dbf (runtime/pprof.TestCPUProfileRecursion.func1:329) 0x10014354f (runtime/pprof.testCPUProfile:451) 0x100142e7f (runtime/pprof.TestCPUProfileRecursion:328) 0x1000d3b17 (testing.tRunner:1439) labels: map[]
        
    pprof_test.go:595: runtime/pprof.inlinedCallee: 4
    pprof_test.go:595: runtime/pprof.recursionCallee: 4
    pprof_test.go:595: runtime/pprof.recursionCaller: 4
    pprof_test.go:341: want at most one recursionCaller or recursionCallee in one Location, got a violating Location (index: 8):
        PeriodType: cpu nanoseconds
        Period: 10000000
        Time: 2022-03-08 16:15:47.241425 -0600 CST
        Duration: 201.511ms
        Samples:
        samples/count cpu/nanoseconds
                  1   10000000: 1 2 3 4 5 6 7 8 
                  1   10000000: 9 2 2 3 4 5 6 7 8 
                  1   10000000: 10 2 3 4 5 6 7 8 
                  1   10000000: 9 2 3 4 5 6 7 8 
        Locations
             1: 0x100143130 M=1 runtime/pprof.inlinedCallee /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/src/runtime/pprof/pprof_test.go:304 s=0
                     runtime/pprof.recursionCallee /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/src/runtime/pprof/pprof_test.go:355 s=0
             2: 0x100143167 M=1 runtime/pprof.recursionCallee /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/src/runtime/pprof/pprof_test.go:356 s=0
             3: 0x1001430b3 M=1 runtime/pprof.recursionCaller /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/src/runtime/pprof/pprof_test.go:347 s=0
             4: 0x1001415ff M=1 runtime/pprof.cpuHogger /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/src/runtime/pprof/pprof_test.go:41 s=0
             5: 0x100142dbf M=1 runtime/pprof.TestCPUProfileRecursion.func1 /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/src/runtime/pprof/pprof_test.go:329 s=0
             6: 0x10014354f M=1 runtime/pprof.testCPUProfile /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/src/runtime/pprof/pprof_test.go:451 s=0
             7: 0x100142e7f M=1 runtime/pprof.TestCPUProfileRecursion /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/src/runtime/pprof/pprof_test.go:328 s=0
             8: 0x1000d3b17 M=1 testing.tRunner /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/src/testing/testing.go:1439 s=0
             9: 0x100143150 M=1 runtime/pprof.cpuHog0 /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/src/runtime/pprof/pprof_test.go:64 s=0
                     runtime/pprof.inlinedCallee /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/src/runtime/pprof/pprof_test.go:304 s=0
                     runtime/pprof.recursionCallee /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/src/runtime/pprof/pprof_test.go:355 s=0
                     runtime/pprof.recursionCallee /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/src/runtime/pprof/pprof_test.go:355 s=0
            10: 0x100143140 M=1 runtime/pprof.cpuHog0 /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/src/runtime/pprof/pprof_test.go:61 s=0
                     runtime/pprof.inlinedCallee /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/src/runtime/pprof/pprof_test.go:304 s=0
                     runtime/pprof.recursionCallee /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/src/runtime/pprof/pprof_test.go:355 s=0
                     runtime/pprof.recursionCallee /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/src/runtime/pprof/pprof_test.go:355 s=0
        Mappings
        1: 0x0/0x0/0x0   [FN]
FAIL

https://build.golang.org/log/529ceab515c1e7ba044f013998b4e8fe37116727
https://build.golang.org/log/a78f4de68188217d3c3da764abcaa976646bc0e8
https://build.golang.org/log/8117a0d8f8a27a6c5dea5027c2934e05d7c57be1

cc @golang/runtime @rhysh
@prattmic prattmic added NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels Mar 9, 2022
@prattmic prattmic added this to the Go1.19 milestone Mar 9, 2022
@gopherbot
Copy link

Change https://go.dev/cl/391134 mentions this issue: runtime/pprof: fix pcDeck's frame indexing

@rsc rsc unassigned rhysh Jun 22, 2022
@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.19
Development

No branches or pull requests
3 participants
@rhysh @prattmic @gopherbot