Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: update to latest spec just before release #51532

Closed
griesemer opened this issue Mar 7, 2022 · 5 comments
Closed

x/website: update to latest spec just before release #51532

griesemer opened this issue Mar 7, 2022 · 5 comments
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.18

Comments

@griesemer
Copy link
Contributor

griesemer commented Mar 7, 2022 •
edited
Loading

To get the most up-to-date spec into the 1.18 release, rather than cherry-picking possibly multiple CLs until the release, we should create a single CL (immediately before the release) in the release branch which contains a 1:1 copy of the latest spec at tip.

cc: @dmitshur
@griesemer griesemer added Documentation Issues describing a change to documentation. release-blocker labels Mar 7, 2022
@griesemer griesemer added this to the Go1.18 milestone Mar 7, 2022
@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 8, 2022
@dmitshur dmitshur mentioned this issue Mar 8, 2022
Closed
33 tasks
@dmitshur dmitshur self-assigned this Mar 10, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/392674 mentions this issue: [release-branch.go1.18] doc: update go_spec.html with latest changes

@gopherbot
Copy link
Contributor

Closed by merging 428533f to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue Mar 14, 2022
@dmitshur
[release-branch.go1.18] doc: update go_spec.html with latest changes
428533f 
Generated at 2022-03-14 14:50 (EDT) with:

	git fetch
	git checkout origin/master -- doc/go_spec.html

This includes spec changes up to CL 391754.

Fixes #51532.

Change-Id: I2c23d764ffa33f24647cd2a4060268c1500f6f99
Reviewed-on: https://go-review.googlesource.com/c/go/+/392674
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
@zigo101
Copy link

zigo101 commented Mar 15, 2022

Just found there a dup is in spec. Just search is is.

@griesemer
Copy link
Contributor Author

@go101 I will take care of this for the next version. Thanks.

@zigo101
Copy link

zigo101 commented Apr 5, 2022

Some inconsistencies between spec and gc:

  • a call to the close function doesn't require its argument has a core type, but spec says it requires.
  • for a neither a map nor a type parameter container, index expression is not required to have a core type, but the spec says it is required (I have mentioned this several times and still think it is not right described in the spec)

@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
4 participants
@dmitshur @griesemer @gopherbot @zigo101