New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/types, types2: report better errors when type sets are empty #51525
Labels
Milestone
Comments
griesemer
added
the
NeedsFix
The path to resolution is known, but the work has not been done.
label
Mar 7, 2022
Change https://go.dev/cl/413934 mentions this issue: |
Addressed for == in 1.19. Moving to 1.20 for the rest. |
gopherbot
pushed a commit
that referenced
this issue
Jun 24, 2022
For #51525. Change-Id: I3762bc4a48a1aaab3b006b1ad1400f866892243c Reviewed-on: https://go-review.googlesource.com/c/go/+/413934 TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Robert Griesemer <gri@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> Reviewed-by: Robert Findley <rfindley@google.com>
jproberts
pushed a commit
to jproberts/go
that referenced
this issue
Aug 10, 2022
For golang#51525. Change-Id: I3762bc4a48a1aaab3b006b1ad1400f866892243c Reviewed-on: https://go-review.googlesource.com/c/go/+/413934 TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Robert Griesemer <gri@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> Reviewed-by: Robert Findley <rfindley@google.com>
Change https://go.dev/cl/452535 mentions this issue: |
felixge
pushed a commit
to felixge/go
that referenced
this issue
Nov 21, 2022
This leads to better error messages where operations are not permitted because of empty type sets. Fixes golang#51525. Change-Id: I8d15645e2aff5145e458bdf9aaa4d2bee28d37fa Reviewed-on: https://go-review.googlesource.com/c/go/+/452535 Auto-Submit: Robert Griesemer <gri@google.com> Reviewed-by: Robert Findley <rfindley@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Robert Griesemer <gri@google.com> Reviewed-by: Robert Griesemer <gri@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Error messages are confusing when type sets are empty. For instance, for:
the error doesn't say why the comparison is not possible. The root cause is that
T
's type set is empty.The same applies to other operations, such as
+
in this case.cc: @findleyr
The text was updated successfully, but these errors were encountered: