Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/elliptic: mention P-521 slowdown in Go 1.18 release notes #51508

Closed
pascaldekloe opened this issue Mar 6, 2022 · 5 comments
Closed

crypto/elliptic: mention P-521 slowdown in Go 1.18 release notes #51508

pascaldekloe opened this issue Mar 6, 2022 · 5 comments
Labels
Documentation FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Milestone

Comments

@pascaldekloe
Copy link
Contributor

pascaldekloe commented Mar 6, 2022

The release notes for Go 1.18 state “P-224 and P-384 are now approximately four times faster.”, which is correct. However, it fails to mention the two times slower for P-521. I would argue that such a significant loss in performance is something people should be aware of.

@ALTree
Copy link
Member

ALTree commented Mar 6, 2022

cc @FiloSottile

@ALTree ALTree changed the title elliptic: Mention P-521 slowdown in Go 1.18 release notes. crypto/elliptic: Mention P-521 slowdown in Go 1.18 release notes. Mar 6, 2022
@ALTree ALTree changed the title crypto/elliptic: Mention P-521 slowdown in Go 1.18 release notes. crypto/elliptic: mention P-521 slowdown in Go 1.18 release notes Mar 6, 2022
@ALTree ALTree added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Mar 6, 2022
@bcmills bcmills added this to the Go1.18 milestone Mar 8, 2022
@dibrinsofor
Copy link

@bcmills can I take this up?

@dmitshur
Copy link
Contributor

@dibrinsofor Thanks, it's fine to prepare a CL as long as you're taking into account that this issue is currently in NeedsDecision state.

@heschi heschi modified the milestones: Go1.18, Go1.19 Mar 15, 2022
@ianlancetaylor
Copy link
Contributor

CC @golang/security

This issue is about the 1.18 (not 1.19) release notes. I'm not sure exactly what to write. Anybody want to send a patch? Thanks.

@pascaldekloe
Copy link
Contributor Author

It's way too late now. 🤣

@golang golang locked and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Projects
Development

No branches or pull requests

8 participants