Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: timeout in TestNoShrinkStackWhileParking on openbsd #51482

Open
prattmic opened this issue Mar 4, 2022 · 5 comments
Open

runtime: timeout in TestNoShrinkStackWhileParking on openbsd #51482

prattmic opened this issue Mar 4, 2022 · 5 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-OpenBSD
Milestone
Backlog

Comments

@prattmic
Copy link
Member

prattmic commented Mar 4, 2022

greplogs --dashboard -md -l -e 'TestNoShrinkStackWhileParking'

2022-01-06T19:21:12-ed84a83/openbsd-386-70-n1
2021-11-27T23:25:39-7e1260f/openbsd-amd64-70-n1
2021-11-08T21:45:43-cc49178/openbsd-386-68

cc @golang/runtime @bcmills
@prattmic prattmic added this to the Go1.19 milestone Mar 4, 2022
@prattmic
Copy link
Member Author

prattmic commented Mar 4, 2022

See also #49382 on netbsd

@prattmic
Copy link
Member Author

prattmic commented Mar 4, 2022

Also on a trybot: https://storage.googleapis.com/go-build-log/a9ef3900/openbsd-amd64-70_e761617c.log

@bcmills
Copy link
Contributor

bcmills commented Mar 4, 2022 •
edited
Loading

It's interesting that the recv goroutine in all of those dumps is parked in time.Sleep(10 * time.Microsecond) rather than the channel-receive that follows it.

@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 5, 2022
@bcmills
Copy link
Contributor

bcmills commented Mar 16, 2022

One more on the builders, still OpenBSD. (Marking as release-blocker, but since OpenBSD is not a first-class port it would be fine to add a skip for that GOOS and move this to the Backlog.)

greplogs --dashboard -md -l -e '(?ms)(?:SIGQUIT|test timed out).*^runtime_test\.TestNoShrinkStackWhileParking' --since=2022-03-04

2022-03-16T15:20:22-1a2f726/openbsd-amd64-68

@dmitshur dmitshur self-assigned this Apr 13, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/401335 mentions this issue: runtime: skip TestNoShrinkStackWhileParking on openbsd

@dmitshur dmitshur removed their assignment Apr 20, 2022
@dmitshur dmitshur modified the milestones: Go1.19, Backlog Apr 22, 2022
gopherbot pushed a commit that referenced this issue Apr 22, 2022
@dmitshur @gopherbot
runtime: skip TestNoShrinkStackWhileParking on openbsd
534a911 
The test has proven to be flaky on OpenBSD since March, and there
hasn't been progress on resolving this finding. Mark the test as
flaky to so that this problem doesn't block the Go 1.19 release.

Updates #51482.

Change-Id: I92ad7498c20cfa94565880363bec85f9a4f3e916
Reviewed-on: https://go-review.googlesource.com/c/go/+/401335
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-OpenBSD
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@cagedmantis @prattmic @dmitshur @bcmills @gopherbot