Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syscall: TestRlimit fails on arm7hl Linux in 1.18rc1 #51479

Closed
alexsaezm opened this issue Mar 4, 2022 · 8 comments
Closed

syscall: TestRlimit fails on arm7hl Linux in 1.18rc1 #51479

alexsaezm opened this issue Mar 4, 2022 · 8 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.18

Comments

@alexsaezm
Copy link
Contributor

What version of Go are you using (go version)?

$ go version
go version go1.18rc1 linux/arm

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="arm"
GOBIN=""
GOCACHE="/home/alex/.cache/go-build"
GOENV="/home/alex/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="arm"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/alex/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/alex/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/alex/src/github.com/golang/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/alex/src/github.com/golang/go/pkg/tool/linux_arm"
GOVCS=""
GOVERSION="go1.18rc1"
GCCGO="gccgo"
GOARM="7"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -marm -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build1876570945=/tmp/go-build -gno-record-gcc-
switches"

What did you do?

While preparing the Fedora package update for the next Go 1.18 release, I found that TestRlimit fails on arm7hl as you can see in this build. You can see the whole build log here in case someone is interested.
But the failure can be reproduce outside the Fedora build system:

[alex@ibm-p8-kvm-03-guest-02 src]$ ../bin/go test syscall -run ^TestRlimit$ -v
=== RUN   TestRlimit
    syscall_unix_test.go:349: Rlimit: change failed: wanted syscall.Rlimit{Cur:0xfffffffffffffffe, Max:0xffffffffffffffff} go
t syscall.Rlimit{Cur:0xffffffffffffffff, Max:0xffffffffffffffff}
--- FAIL: TestRlimit (0.01s)
FAIL
FAIL	syscall	0.216s
FAIL

I cannot reproduce it with previous versions, so I bet it might be related to this commit.

What did you expect to see?

No failing tests.

What did you see instead?

A failing test.
@ianlancetaylor
Copy link
Contributor

CC @tamird

@ianlancetaylor
Copy link
Contributor

I don't understand why the kernel is ignoring the requested change. What version of the kernel are you running?

@ianlancetaylor ianlancetaylor added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Mar 4, 2022
@ianlancetaylor ianlancetaylor added this to the Go1.18 milestone Mar 4, 2022
@alexsaezm
Copy link
Contributor Author

I don't understand why the kernel is ignoring the requested change. What version of the kernel are you running?

In the build system where I first saw the issue we have right now this version:

5.16.7-200.fc35.armv7hl+lpae

In the virtual machine where I can reproduce it:

5.14.10-300.fc35.armv7hl

Both are the standard packages that Fedora 35 and Fedora 36 ship.

@ianlancetaylor
Copy link
Contributor

I think this test is more trouble than it's worth.

@gopherbot
Copy link

Change https://go.dev/cl/390020 mentions this issue: syscall: remove TestRlimit

@ianlancetaylor ianlancetaylor mentioned this issue Mar 4, 2022
Closed
33 tasks
@ianlancetaylor
Copy link
Contributor

Reopening for 1.18 backport.

@ianlancetaylor ianlancetaylor reopened this Mar 4, 2022
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Mar 4, 2022
@gopherbot
Copy link

Change https://go.dev/cl/390022 mentions this issue: [release-branch.go1.18] syscall: remove TestRlimit

gopherbot pushed a commit that referenced this issue Mar 7, 2022
@ianlancetaylor @dmitshur
[release-branch.go1.18] syscall: remove TestRlimit
520f0d0 
It's more trouble than it's worth. New code should be using x/sys/unix
anyhow.

Fixes #40564
Fixes #51479

Change-Id: I1c0e13f494380c1565e98359f088af9f52790b79
Reviewed-on: https://go-review.googlesource.com/c/go/+/390020
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 1e122e3)
Reviewed-on: https://go-review.googlesource.com/c/go/+/390022
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@dmitshur
Copy link
Contributor

dmitshur commented Mar 7, 2022

Closed by merging commit 520f0d0 (CL 390022) to release-branch.go1.18.

@dmitshur dmitshur closed this as completed Mar 7, 2022
@golang golang locked and limited conversation to collaborators Mar 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
4 participants
@dmitshur @alexsaezm @ianlancetaylor @gopherbot