Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

affected/package: vcs: 1.18 requires a new minimum git version #51467

Closed
howardjohn opened this issue Mar 4, 2022 · 1 comment
Closed

affected/package: vcs: 1.18 requires a new minimum git version #51467

howardjohn opened this issue Mar 4, 2022 · 1 comment

Comments

@howardjohn
Copy link
Contributor

What version of Go are you using (go version)?

$ go version
1.18rc1

Does this issue reproduce with the latest release?

Yes, it is a regression in 1.18rc1 from 1.17

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN="/gobin"
GOCACHE="/gocache"
GOENV="/home/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.18rc1"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/work/go.mod"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build3992160965=/tmp/go-build -gno-record-gcc-switches"

What did you do?

go mod tidy

What did you expect to see?

Success

What did you see instead?

�[0mtest/envoye2e/stackdriver_plugin/cmd/main.go:1: : error obtaining VCS status: exit status 128
	Use -buildvcs=false to disable VCS stamping. (typecheck)
// Copyright 2019 Istio Authors

The weird thing is this seems semi-inconsistent. It fails 100% of the time in our CI after updating to go 1.18, but running locally its inconsistent. Sometimes I can run it 100 times in a row with the same issue, while other times it works 10000 times in a row. I cannot explain this - possibly a cache...?

Root cause

The root cause seems to be b1a53ece68d. I think an approach similar to 90066bf can be used and is more compatible. I will send a fix myself if I am able to get the contribution setup for Go working.

@seankhliao
Copy link
Member

Duplicate of #51253

@seankhliao seankhliao marked this as a duplicate of #51253 Mar 4, 2022
howardjohn added a commit to howardjohn/go that referenced this issue Mar 4, 2022
Fixes golang#51467.

This uses the same flag already used in
`src/cmd/go/internal/modfetch/codehost/git.go`, and avoids using a new
flag that breaks Ubuntu 16 and Centos 7's latest git.
@golang golang locked and limited conversation to collaborators Mar 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants