Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/relui: redirect should take -base-url into account #51466

Closed
dmitshur opened this issue Mar 3, 2022 · 1 comment
Closed

x/build/cmd/relui: redirect should take -base-url into account #51466

dmitshur opened this issue Mar 3, 2022 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Mar 3, 2022

relui supports serving its UI at a URL with a path prefix via the -base-url flag.

As reported by @cagedmantis, when a non-empty path prefix is used, redirection that happens when a new workflow is created should take it into account. It currently always redirects to / instead.
@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels Mar 3, 2022
@dmitshur dmitshur added this to the Unreleased milestone Mar 3, 2022
@dmitshur dmitshur self-assigned this Apr 22, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/401796 mentions this issue: cmd/relui: redirect to base URL after creating a workflow

@heschi heschi moved this to Done in Go Release Sep 27, 2022
@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot