Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: TestListenerClose failures with "bind: address already in use" #51441

Closed
bcmills opened this issue Mar 2, 2022 · 2 comments
Closed

net: TestListenerClose failures with "bind: address already in use" #51441

bcmills opened this issue Mar 2, 2022 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.19

Comments

@bcmills
Copy link
Contributor

bcmills commented Mar 2, 2022 

--- FAIL: TestListenerClose (0.00s)
    --- FAIL: TestListenerClose/unix (0.00s)
        mockserver_test.go:68: listen unix /tmp/workdir-host-solaris-oracle-amd64-oraclerel/tmp/1541094240/sock: bind: address already in use
FAIL
FAIL	net	14.848s

greplogs --dashboard -md -l -e 'bind: address already in use\n(?:.*\n)*FAIL\s+net\s+' --since=2021-12-13

2022-03-01T06:01:28-4f04e1d/solaris-amd64-oraclerel

This failure mode was supposed to be fixed by CL 370696 (CC @ianlancetaylor), but evidently I missed a racy test somewhere.
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 2, 2022
@bcmills bcmills added this to the Backlog milestone Mar 2, 2022
@bcmills bcmills mentioned this issue Apr 20, 2022
Open
@bcmills bcmills self-assigned this May 9, 2022
@bcmills bcmills modified the milestones: Backlog, Go1.19 May 9, 2022
@bcmills
Copy link
Contributor Author

bcmills commented May 9, 2022

Found a racy path-reuse in TestListenConfigControl/PacketListen. Here's hoping that's the one. 🤞

@gopherbot
Copy link

Change https://go.dev/cl/405214 mentions this issue: net: avoid racing on port reuse in TestListenConfigControl

@rsc rsc unassigned bcmills Jun 22, 2022
@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Go1.19
Development

No branches or pull requests
2 participants
@bcmills @gopherbot