Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/exp/maps: build is failing as of CL 387977 #51438

Closed
findleyr opened this issue Mar 2, 2022 · 1 comment
Closed

x/exp/maps: build is failing as of CL 387977 #51438

findleyr opened this issue Mar 2, 2022 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.18

Comments

@findleyr
Copy link
Contributor

findleyr commented Mar 2, 2022

https://go.dev/cl/387977 (correctly consider ~ (tilde) in constraint type inference) seems to have broken the build of the x/exp/maps package:

https://build.golang.org/?repo=golang.org%2fx%2fexp

Sample:

# golang.org/x/exp/maps [golang.org/x/exp/maps.test]
maps/maps_test.go:55:10: cannot infer M2 (/var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/gopath/src/golang.org/x/exp/maps/maps.go:30:16)
maps/maps_test.go:58:10: cannot infer M1 (/var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/gopath/src/golang.org/x/exp/maps/maps.go:30:12)
maps/maps_test.go:95:14: cannot infer M2 (/var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/gopath/src/golang.org/x/exp/maps/maps.go:44:30)
maps/maps_test.go:98:14: cannot infer M1 (/var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/gopath/src/golang.org/x/exp/maps/maps.go:44:16)
maps/maps_test.go:129:11: cannot infer M2 (/var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/gopath/src/golang.org/x/exp/maps/maps.go:30:16)

This is probably expected, but should be investigated (and fixed) for 1.18. CC @griesemer @ianlancetaylor
@findleyr findleyr added this to the Go1.18 milestone Mar 2, 2022
@griesemer griesemer self-assigned this Mar 2, 2022
@griesemer griesemer added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 2, 2022
@griesemer griesemer mentioned this issue Mar 2, 2022
Closed
@gopherbot
Copy link

Change https://go.dev/cl/389374 mentions this issue: x/exp/maps: fix tests

@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
4 participants
@bcmills @griesemer @gopherbot @findleyr