cmd/go: Builds using go1.16.x report an ambiguous error when an imported dependency contains '//go:build' but not '// +build' #51436

dylan-bourque · 2022-03-02T18:27:54Z

What version of Go are you using (`go version`)?

$ go version
go version go1.16.7 darwin/amd64

Does this issue reproduce with the latest release?

No. Both go1.17 and go1.18rc1 work correctly.

What operating system and processor architecture are you using (`go env`)?

go env Output

$ go env
GO111MODULE="auto"
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/dbourque/Library/Caches/go-build"
GOENV="/Users/dbourque/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/dbourque/sdk/modcache"
GOOS="darwin"
GOPATH="/Users/dbourque/dev/golang"
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/Users/dbourque/sdk/go1.16.7"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/Users/dbourque/sdk/go1.16.7/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.16.7"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/var/folders/3t/4048hqr5459dw83ksmkqxn7r0000gn/T/tmp.VldrLY60/go.mod"
CGO_CFLAGS=""
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="/usr/local/bin/pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/3t/4048hqr5459dw83ksmkqxn7r0000gn/T/go-build405126792=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

Several of our internal modules at work have recently started failing to build with an error that says nothing more than //go:build comment without // +build comment. We were able to determine that the error only happens for things that are still on Go 1.16.x and upgrading them to 1.17 made the error go away.

Further digging revealed that the actual problem was within the bitbucket.org/bertimus9/systemstat module, which removed // +build directive comments with this commit, purportedly to "update to play nice with go 1.17".

The snippet below is a minimal reproducible example (included here because go.dev/play doesn't seem to have an option to use go1.16.x):

package main

import (
	"fmt"

	"bitbucket.org/bertimus9/systemstat"
)

func main() {
	var v systemstat.CPUAverage

	fmt.Printf("%v\n", v)
}

Attempting to build the code above generates the following error when using Go 1.16.x:

$go run main.go
main.go:6:2: //go:build comment without // +build comment

The behavior is correct according to this proposal, but the error message gives no indication that the missing // +build directive inside of a dependency. Instead it shows the source/line information for the import of the "bad" package.

What did you expect to see?

An error with the source/line information pointing to the dependency's code, where the problem actually exists.

What did you see instead?

An error with the source/line information pointing at my own code with no explanation that the issue actually exists elsewhere.

The text was updated successfully, but these errors were encountered:

bcmills · 2022-03-02T19:15:13Z

I'd like to figure out whether this also affects Go at tip (perhaps in a different form). If it doesn't, then this probably isn't worth fixing (since Go 1.16 is EOL in about a month), but the root cause may point to a similar or different symptom of a problem that still exists.

dylan-bourque · 2022-03-02T20:36:26Z

Agreed. I don't think it needs to be addressed for 1.16.x given that 1.18 is due to be released presently (rc1 is available as I post this), but the abstract issue of the error not showing the "correct" source/line info is valid and should be addressed if possible.

bcmills · 2022-11-09T20:39:51Z

I suspect that there may still be some related bugs in how we attribute errors for various failure modes, but it's been long enough that I don't expect to be able to chase this one down based on the original reproducer. 😞

I'm definitely still interested in fixing these bugs, but I'm going to close this particular issue as “probably not a productive avenue of investigation any more”.

gopherbot · 2022-11-09T20:42:45Z

Change https://go.dev/cl/448996 mentions this issue: slices: add old build constraint syntax to help old go versions

gopherbot · 2022-11-09T20:45:34Z

Change https://go.dev/cl/449175 mentions this issue: x/vuln/internal: add old build constraint syntax

When a project transitively depends on x/vuln/internal, go1.16 is confused and fails with errors like "//go:build comment without // +build comment" Even when conditionally import x/vuln/internal only for go1.18+, this error is unavoidable. Let's wait a bit longer and help users who are stuck with old go. Updates golang/go#51436 Change-Id: I22fce4c037bef3621800a7cca31d31938025078a Reviewed-on: https://go-review.googlesource.com/c/vuln/+/449175 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Bryan Mills <bcmills@google.com> Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>

When a project transitively depends on x/exp/slices, go1.16 is confused and fails with errors like: "//go:build comment without // +build comment" Even when import of x/exp/slices guarded with build tags, so this is imported only when compiling with go1.18, this error is unavoidable. Let's wait a bit longer and help users who are stuck with old go. Updates golang/go#51436 Change-Id: I7ba589644475f55585c11ba1f7650c5ede6bc637 Reviewed-on: https://go-review.googlesource.com/c/exp/+/448996 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Bryan Mills <bcmills@google.com> Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>

Go 1.16 has a bug that causes build failure (ex: https://github.com/goto/meteor/actions/runs/4434675833/jobs/7780899433#step:4:435). Go issue - golang/go#51436

- Upgrade Go version to 1.20. Go 1.16 has a bug that causes build failure (ex: https://github.com/goto/meteor/actions/runs/4434675833/jobs/7780899433#step:4:435). Go issue - golang/go#51436

When a project transitively depends on x/vuln/internal, go1.16 is confused and fails with errors like "//go:build comment without // +build comment" Even when conditionally import x/vuln/internal only for go1.18+, this error is unavoidable. Let's wait a bit longer and help users who are stuck with old go. Updates golang/go#51436 Change-Id: I22fce4c037bef3621800a7cca31d31938025078a Reviewed-on: https://go-review.googlesource.com/c/vuln/+/449175 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Bryan Mills <bcmills@google.com> Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>

bcmills self-assigned this Mar 2, 2022

bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 2, 2022

bcmills added this to the Go1.19 milestone Mar 2, 2022

bcmills added the GoCommand cmd/go label Mar 2, 2022

bcmills modified the milestones: Go1.19, Backlog May 31, 2022

mutahhir mentioned this issue Oct 21, 2022

chore(deps): Update docker image to use new jsii/superchain tag hashicorp/terraform-cdk#2214

Merged

bcmills removed their assignment Nov 9, 2022

bcmills closed this as completed Nov 9, 2022

bcmills added the Unfortunate label Nov 9, 2022

sudo-suhas added a commit to goto/meteor that referenced this issue Mar 16, 2023

fix: upgrade Go version to 1.20

2db1b69

Go 1.16 has a bug that causes build failure (ex: https://github.com/goto/meteor/actions/runs/4434675833/jobs/7780899433#step:4:435). Go issue - golang/go#51436

sudo-suhas mentioned this issue Mar 16, 2023

feat: migrate to gotocompany goto/meteor#1

Merged

sudo-suhas added a commit to goto/meteor that referenced this issue Mar 16, 2023

fix: upgrade Go version to 1.20

6e51e75

Go 1.16 has a bug that causes build failure (ex: https://github.com/goto/meteor/actions/runs/4434675833/jobs/7780899433#step:4:435). Go issue - golang/go#51436

sudo-suhas added a commit to goto/meteor that referenced this issue Mar 16, 2023

fix: upgrade Go version to 1.20

99fb712

Go 1.16 has a bug that causes build failure (ex: https://github.com/goto/meteor/actions/runs/4434675833/jobs/7780899433#step:4:435). Go issue - golang/go#51436

dnephin mentioned this issue Sep 29, 2023

error when go install v1.11.0 gotestyourself/gotestsum#372

Open

golang locked and limited conversation to collaborators Nov 9, 2023

gopherbot added the FrozenDueToAge label Nov 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cmd/go: Builds using go1.16.x report an ambiguous error when an imported dependency contains '//go:build' but not '// +build' #51436

cmd/go: Builds using go1.16.x report an ambiguous error when an imported dependency contains '//go:build' but not '// +build' #51436

dylan-bourque commented Mar 2, 2022

bcmills commented Mar 2, 2022

dylan-bourque commented Mar 2, 2022

bcmills commented Nov 9, 2022

gopherbot commented Nov 9, 2022

gopherbot commented Nov 9, 2022

cmd/go: Builds using go1.16.x report an ambiguous error when an imported dependency contains '//go:build' but not '// +build' #51436

cmd/go: Builds using go1.16.x report an ambiguous error when an imported dependency contains '//go:build' but not '// +build' #51436

Comments

dylan-bourque commented Mar 2, 2022

What version of Go are you using (go version)?

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

What did you do?

What did you expect to see?

What did you see instead?

bcmills commented Mar 2, 2022

dylan-bourque commented Mar 2, 2022

bcmills commented Nov 9, 2022

gopherbot commented Nov 9, 2022

gopherbot commented Nov 9, 2022

What version of Go are you using (`go version`)?

What operating system and processor architecture are you using (`go env`)?