Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: most recently closed type checker CLs must be cherry-picked into release branch #51421

Closed
griesemer opened this issue Mar 2, 2022 · 2 comments
Closed

cmd/compile: most recently closed type checker CLs must be cherry-picked into release branch #51421

griesemer opened this issue Mar 2, 2022 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.18

Comments

@griesemer
Copy link
Contributor

griesemer commented Mar 2, 2022 •
edited by dmitshur

The following three CLs need to be cherry-picked into the release branch, in the listed order:

  1. CL 387977
  2. CL 388294
  3. CL 389594

Before doing so, we should verify that everything from the go/types, types2 side before these two CLs is already in the release branch. The go/types, types2 CL immediately before 1. is CL 388254 . If it's not present, we may need to review more closely what needs to be cherry-picked.

cc: @golang/release
@griesemer griesemer added this to the Go1.18 milestone Mar 2, 2022
@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 2, 2022
@dmitshur
Copy link
Contributor

dmitshur commented Mar 2, 2022

Thanks for filing the tracking issue for this. We'll make sure it's done before the final release, and close this issue then.

Before doing so, we should verify that everything from the go/types, types2 side before these two CLs is already in the release branch. The go/types, types2 CL immediately before 1. is CL 388254 .

CL 388254 was submitted to the master branch before the "Go 1.19 development begins" CL 388376 dividing line, so it should make its way to release-branch.go1.18 as part of the normal release process.

@griesemer
Copy link
Contributor Author

Closing as duplicate of #51460 now that we have that umbrella issue.

@golang golang locked and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
3 participants
@dmitshur @griesemer @gopherbot