Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/types, types2: report error in case of infinite recursion during unification #51377

Closed
griesemer opened this issue Feb 26, 2022 · 2 comments
Closed

go/types, types2: report error in case of infinite recursion during unification #51377

griesemer opened this issue Feb 26, 2022 · 2 comments
Labels
early-in-cycle A change that should be done early in the 3 month dev cycle. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.19

Comments

@griesemer
Copy link
Contributor

With CL 385494 we shouldn't see (and haven't seen) infinite recursions in unification. We should report a suitable error if we notice an infinite recursion instead of silently aborting (or panicking).
@griesemer griesemer added NeedsFix The path to resolution is known, but the work has not been done. early-in-cycle A change that should be done early in the 3 month dev cycle. labels Feb 26, 2022
@griesemer griesemer added this to the Go1.19 milestone Feb 26, 2022
@griesemer griesemer self-assigned this Feb 26, 2022
@gopherbot
Copy link

Change https://go.dev/cl/392755 mentions this issue: go/types, types2: re-enable panic if unification stack-overflows

@gopherbot
Copy link

This issue is currently labeled as early-in-cycle for Go 1.19.
That time is now, so a friendly reminder to look at it again.

@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
early-in-cycle A change that should be done early in the 3 month dev cycle. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.19
Development

No branches or pull requests
2 participants
@griesemer @gopherbot