Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/types, types2: revisit core type unification in the presence of ~ constraints #51376

Closed
griesemer opened this issue Feb 26, 2022 · 2 comments
Closed

go/types, types2: revisit core type unification in the presence of ~ constraints #51376

griesemer opened this issue Feb 26, 2022 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.18

Comments

@griesemer
Copy link
Contributor

Reminder issue to revisit the fix/tests for:

which depend on core type unification for non-local (unbound) type parameters. The examples/test may not be correct in the presence of ~ in constraints. See #51229 for the impact of ~ in constraint type inference.

cc: @findleyr
@griesemer griesemer added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 26, 2022
@griesemer griesemer added this to the Go1.18 milestone Feb 26, 2022
@griesemer griesemer self-assigned this Feb 26, 2022
@griesemer griesemer changed the title cmd/compile: revisit core type unification in the presence of ~ constraints go/types, types2: revisit core type unification in the presence of ~ constraints Feb 26, 2022
@gopherbot
Copy link

Change https://go.dev/cl/388294 mentions this issue: go/types, types2: clarify a comment and add an extra test

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Mar 4, 2022
@gopherbot
Copy link

Change https://go.dev/cl/390016 mentions this issue: [release-branch.go1.18] go/types, types2: clarify a comment and add an extra test

gopherbot pushed a commit that referenced this issue Mar 4, 2022
@griesemer @dmitshur
[release-branch.go1.18] go/types, types2: clarify a comment and add a…
77a1424 
…n extra test

Confirm that the current implementation of core type unification
looks correct and update the respective comment. Add an extra test.

Fixes #51376.

Change-Id: I6a603a4baeee2ede5bb4a1d60766204a808936d7
Reviewed-on: https://go-review.googlesource.com/c/go/+/388294
Trust: Robert Griesemer <gri@golang.org>
Run-TryBot: Robert Griesemer <gri@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 6da16b6)
Reviewed-on: https://go-review.googlesource.com/c/go/+/390016
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
3 participants
@dmitshur @griesemer @gopherbot