Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: "v1.x.y is not a tag" when .gitconfig sets log.decorate to full [1.17 backport] #51351

Closed
gopherbot opened this issue Feb 24, 2022 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@gopherbot
Copy link

@bcmills requested issue #51312 to be considered for backport to the next 1.17 minor release.

@gopherbot, please backport to Go 1.16 and 1.17. This causes erroneous error messages (which may be confusing for users), and the underlying cause is not easy to diagnose.

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 24, 2022
@gopherbot gopherbot added this to the Go1.17.8 milestone Feb 24, 2022
@dmitshur dmitshur added the GoCommand cmd/go label Feb 24, 2022
@bcmills bcmills changed the title cmd/go: unexpected "v1.x.y is not a tag" after update to Go 1.16.14 [1.17 backport] cmd/go: "v1.x.y is not a tag" when .gitconfig sets log.decorate to full [1.17 backport] Feb 24, 2022
@cagedmantis cagedmantis modified the milestones: Go1.17.8, Go1.17.9 Mar 3, 2022
@dmitshur dmitshur modified the milestones: Go1.17.9, Go1.17.10 Apr 12, 2022
@heschi heschi modified the milestones: Go1.17.10, Go1.17.11 May 10, 2022
@dmitshur dmitshur modified the milestones: Go1.17.11, Go1.17.12 Jun 1, 2022
@bcmills bcmills added CherryPickApproved Used during the release process for point releases NeedsFix The path to resolution is known, but the work has not been done. labels Jun 28, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jun 28, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/414875 mentions this issue: [release-branch.go1.18] cmd/go: pass --no-decorate when listing git tags for a commit

@gopherbot
Copy link
Author

Change https://go.dev/cl/414875 mentions this issue: [release-branch.go1.17] cmd/go: pass --no-decorate when listing git tags for a commit

@gopherbot
Copy link
Author

Closed by merging 77cc1c0 to release-branch.go1.17.

gopherbot pushed a commit that referenced this issue Jul 6, 2022
…ags for a commit

This avoids a parse error when the user's global .gitconfig sets
log.decorate to true.

Updates #51312.
Fixes #51351.

Change-Id: Ic47b0f604c0c3a404ec50d6e09f4e138045ac2f2
Reviewed-on: https://go-review.googlesource.com/c/go/+/387835
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
(cherry picked from commit a30f434)
Reviewed-on: https://go-review.googlesource.com/c/go/+/414875
@golang golang locked and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

5 participants