Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/ipv4: deadlock in TestPacketConnConcurrentReadWriteUnicast #51342

Closed
bcmills opened this issue Feb 24, 2022 · 3 comments
Closed

x/net/ipv4: deadlock in TestPacketConnConcurrentReadWriteUnicast #51342

bcmills opened this issue Feb 24, 2022 · 3 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.19

Comments

@bcmills
Copy link
Contributor

bcmills commented Feb 24, 2022 •
edited

Looks like exactly the same failure mode as in #50455, but for the ipv4 package instead of ipv6.

That probably means we can just port over CL 376094 and CL 376095 to the ipv4 package. We may also want to audit whether any other ipv6 test fixes should be ported to ipv4.

greplogs --dashboard -md -l -e '(?ms)panic: test timed out.*\nsync\.\(\*WaitGroup\)\.Wait.*\n\t.*\ngolang\.org/x/net/ipv4_test.testPacketConnConcurrentReadWriteUnicast'

2022-02-24T00:04:18-cd36cc0-78e9976/freebsd-amd64-13_0
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Feb 24, 2022
@gopherbot gopherbot added this to the Unreleased milestone Feb 24, 2022
@bcmills
Copy link
Contributor Author

bcmills commented Feb 24, 2022

Marking as release-blocker for Go 1.19 due to the similarity to #50455, which was observed on darwin/amd64 (a first-class port).

@bcmills bcmills modified the milestones: Unreleased, Go1.19 Feb 24, 2022
@bcmills bcmills self-assigned this Feb 24, 2022
@gopherbot
Copy link

Change https://go.dev/cl/387915 mentions this issue: ipv4: shut down the PacketConn on failure in TestPacketConnConcurrentReadWriteUnicast

@gopherbot
Copy link

Change https://go.dev/cl/387916 mentions this issue: ipv6: retry ENOBUFS errors in TestPacketConnConcurrentReadWriteUnicast

gopherbot pushed a commit to golang/net that referenced this issue Feb 25, 2022
ipv4: shut down the PacketConn on failure in TestPacketConnConcurrent…
f80d34d 
…ReadWriteUnicast

This avoids a deadlock (observed in golang/go#51342) that may
otherwise swallow the error logs from a failure, which may help us
better diagnose the underlying problem.

This is a port of CL 376094 to the "ipv4" package.

For golang/go#51342

Change-Id: I7b5ba25fcbdd1ec0b319fe35b558d9dcbf8054c6
Reviewed-on: https://go-review.googlesource.com/c/net/+/387915
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@bcmills bcmills mentioned this issue Jun 15, 2022
Closed
@rsc rsc unassigned bcmills Jun 22, 2022
@bcmills bcmills mentioned this issue Nov 4, 2022
Open
WeiminShang added a commit to WeiminShang/net that referenced this issue Nov 16, 2022
@WeiminShang
ipv4: shut down the PacketConn on failure in TestPacketConnConcurrent…
6eaf168 
…ReadWriteUnicast

This avoids a deadlock (observed in golang/go#51342) that may
otherwise swallow the error logs from a failure, which may help us
better diagnose the underlying problem.

This is a port of CL 376094 to the "ipv4" package.

For golang/go#51342

Change-Id: I7b5ba25fcbdd1ec0b319fe35b558d9dcbf8054c6
Reviewed-on: https://go-review.googlesource.com/c/net/+/387915
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
WeiminShang added a commit to WeiminShang/net that referenced this issue Nov 16, 2022
@WeiminShang
ipv4: retry ENOBUFS errors in TestPacketConnConcurrentReadWriteUnicast
8d770ea 
This change is sheer speculation based on the failures observed in
golang/go#37319.

(A deadlock in the test prevented us from seeing the actual failure
mode of golang/go#51342 up until CL 387915, and it isn't obvious to me
that we should wait for another failure before trying a likely — and
otherwise harmless — fix.)

This is a port of CL 376095 to the "ipv4" package.

Fixes golang/go#51342.
(Maybe.)

Change-Id: Idd6d2d785dbb0c98404f99bd98a3c4ddc11cb2cf
Reviewed-on: https://go-review.googlesource.com/c/net/+/387916
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.19
Development

No branches or pull requests
2 participants
@bcmills @gopherbot