Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/url: no default port information after parse URL without explicit port #51329

Closed
kdh6429 opened this issue Feb 23, 2022 · 5 comments
Closed

net/url: no default port information after parse URL without explicit port #51329

kdh6429 opened this issue Feb 23, 2022 · 5 comments
Labels
FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.

Comments

@kdh6429
Copy link

kdh6429 commented Feb 23, 2022 •
edited

What version of Go are you using (go version)?

$ go version
go version go1.17.7 windows/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
set GO111MODULE=
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\ME\AppData\Local\go-build
set GOENV=C:\Users\ME\AppData\Roaming\go\env  
set GOEXE=.exe
set GOEXPERIMENT=
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GOMODCACHE=C:\Users\ME\go\pkg\mod
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=C:\Users\ME\go
set GOPRIVATE=
set GOPROXY=https://proxy.golang.org,direct
set GOROOT=C:\Program Files\Go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLDIR=C:\Program Files\Go\pkg\tool\windows_amd64
set GOVCS=
set GOVERSION=go1.17.7
set GCCGO=gccgo
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=NUL
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=C:\Users\ME\AppData\Local\Temp\go-build2535369338=/tmp/go-build -gno-record-gcc-switches

What did you do?

I tried to convert a string(with no port, 80) address into a URL form with (u *URL) Parse(ref string) (*URL, error)

What did you expect to see?

URL struct that has port as 80

What did you see instead?

"" (empty string)

(u *URL) Parse(ref string) (*URL, error) If there is no port information in the method, I would like to have port 80 by default.
@davecheney
Copy link
Contributor

Thank you for raising this issue. Can you please post a small example program using https://go.dev/play/ that demonstrates the problem.

@davecheney davecheney added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Feb 23, 2022
@mengzhuo mengzhuo changed the title affected/package: net/url net/url: no default port information after parse URL without explicit port Feb 23, 2022
@kdh6429
Copy link
Author

kdh6429 commented Feb 23, 2022

https://go.dev/play/p/ixt68e1izE6
@davecheney I hope this example helps to understand the problem.

@davecheney
Copy link
Contributor

Yes it does, thank you. From my understanding the package is working correctly, there is no port value in that url.

@ianlancetaylor
Copy link
Contributor

Thanks, but the package is working as documented and intended. Even if we wanted to change it, changing it now would likely break existing Go code. It's easy enough to write a little function to do

    port := url.Port()
    if port == "" {
        port = "80"
    }
    return port

@kdh6429
Copy link
Author

kdh6429 commented Feb 23, 2022

Thank you all. As you said, the package is working correctly, and I am writing the code like the sample code above. I was wondering if there is any thought to handle the condition within the package :)

@golang golang locked and limited conversation to collaborators Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@davecheney @ianlancetaylor @kdh6429 @gopherbot