-
Notifications
You must be signed in to change notification settings - Fork 18k
runtime: runtime.racefuncenter: nosplit stack overflow -race, Goland debug 1.18rc1 #51247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Does it set |
yes, I see this: |
I'll look into if we can fix that. But in the meantime, you can use either |
Wow, where is this race fun center? I want to play! |
Is it darwin only? runtime test on linux/arm64(raspi 4) with '-race' and '-N -l' all passed. |
Change https://go.dev/cl/386715 mentions this issue: |
Change https://go.dev/cl/386716 mentions this issue: |
Change https://go.dev/cl/386714 mentions this issue: |
Change https://go.dev/cl/386719 mentions this issue: |
Save some stack space, to avoid nosplit overflow in -race -N -l build. For #51247. Change-Id: I7357d6227f816a612a64f55f7ca1b1384e9268e1 Reviewed-on: https://go-review.googlesource.com/c/go/+/386714 Trust: Cherry Mui <cherryyz@google.com> Run-TryBot: Cherry Mui <cherryyz@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Michael Knyszek <mknyszek@google.com>
They are called from compiler instrumented code as ABIInternal. Define them as ABIInternal to avoid the wrappers and save some stack space, to avoid nosplit overflow in -race -N -l build. For #51247. Change-Id: Iadad7d6da8ac03780a7b02b03b004c52d34e020a Reviewed-on: https://go-review.googlesource.com/c/go/+/386715 Trust: Cherry Mui <cherryyz@google.com> Run-TryBot: Cherry Mui <cherryyz@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Michael Knyszek <mknyszek@google.com>
To avoid nosplit overflow in -race -N -l build. For #51247. Change-Id: I48426bbd4adefd18eaf26ed51b4113c6a28305b8 Reviewed-on: https://go-review.googlesource.com/c/go/+/386716 Trust: Cherry Mui <cherryyz@google.com> Run-TryBot: Cherry Mui <cherryyz@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Michael Knyszek <mknyszek@google.com>
With the CLs above there should be no more nosplit overflow from the standard library on ARM64 with However, I still suggest not to use |
why would we want to remove the ability to do race detection and debugging at the same time? From a dev perspective, I am more likely to run the -race with debugging than I am to swap back and forth. I am also unlikely to compile my production binaries with -race because I won't want the panic. |
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
No, works fine on 1.17.6
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
Running debug on Goland with -race flag. It starts up fine without the -race flag or if I use "run".
What did you expect to see?
My program start up.
What did you see instead?
The text was updated successfully, but these errors were encountered: