Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gccgo: gofrontend: confusing error message #51237

Closed
erifan opened this issue Feb 17, 2022 · 2 comments
Closed

gccgo: gofrontend: confusing error message #51237

erifan opened this issue Feb 17, 2022 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Gccgo

Comments

@erifan
Copy link

erifan commented Feb 17, 2022

What version of Go are you using (go version)?

$ go version
gccgo tip

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
linux/arm64

What did you do?

$ gccgo -c foo.go
$ cat foo.go

package foo

type TypeID unsafe.Pointer

What did you expect to see?

foo.go:3:13: undefined: unsafe

What did you see instead?

foo.go:3:19: error: expected package
3 | type TypeID unsafe.Pointer
|
@seankhliao seankhliao changed the title gofrontend: confusing error message gccgo: gofrontend: confusing error message Feb 17, 2022
@gopherbot gopherbot added this to the Gccgo milestone Feb 17, 2022
@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 17, 2022
@gopherbot
Copy link

Change https://go.dev/cl/415994 mentions this issue: compiler: better error message for unknown package name

@gopherbot
Copy link

Change https://go.dev/cl/416014 mentions this issue: test: recognize new gofrontend error message

gopherbot pushed a commit that referenced this issue Jul 6, 2022
@ianlancetaylor
test: recognize new gofrontend error message
2007599 
The new gofrontend message matches other gofrontend error messages,
so adjust the test to accept it.

For #27938
For #51237

Change-Id: I29b536f83a0cf22b1dbdae9abc2f5f6cf21d522d
Reviewed-on: https://go-review.googlesource.com/c/go/+/416014
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
xionghul pushed a commit to xionghul/gcc that referenced this issue Jul 6, 2022
@ianlancetaylor
compiler: better error message for unknown package name
ccc39d9 
Fixes golang/go#51237

Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/415994
timll pushed a commit to timll/gcc that referenced this issue Jul 16, 2022
@ianlancetaylor @timll
compiler: better error message for unknown package name
a8c80c5 
Fixes golang/go#51237

Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/415994
realqhc pushed a commit to realqhc/gofrontend that referenced this issue Aug 4, 2022
@ianlancetaylor @realqhc
compiler: better error message for unknown package name
182cfc4 
Fixes golang/go#51237

Change-Id: I84c131cc2e8dc791fd4b6e50217167c3d8d97cfb
Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/415994
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
jproberts pushed a commit to jproberts/go that referenced this issue Aug 10, 2022
@ianlancetaylor @jproberts
test: recognize new gofrontend error message
30fc2a5 
The new gofrontend message matches other gofrontend error messages,
so adjust the test to accept it.

For golang#27938
For golang#51237

Change-Id: I29b536f83a0cf22b1dbdae9abc2f5f6cf21d522d
Reviewed-on: https://go-review.googlesource.com/c/go/+/416014
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
@golang golang locked and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Gccgo
Development

No branches or pull requests
3 participants
@dmitshur @gopherbot @erifan